Closed Bug 1330449 Opened 4 years ago Closed 4 years ago

Clarify "Edit" button

Categories

(bugzilla.mozilla.org :: User Interface, defect)

Production
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: KWierso, Unassigned)

Details

Attachments

(2 files)

14:23:52 <hal> question: can the "blocks" & "depends" list be edited in the new modal form? I had to switch to legacy format to find an edit method
14:24:32 <KWierso> hal: if you click the "edit" button, there should be fields for them in the "tracking" section
14:25:05 <hal> KWierso: Thanks -- I didn't think to try the edit button!
14:29:46 — hal thinks labeling the "edit" button to indicate it applies to the meta data might be worth considering
Assignee: nobody → wkocher
Comment on attachment 8825975 [details] [review]
PR 38

Should we do this?

Pros:
More clarity
The button will stay similarly sized with the "Save Changes" button since the number of characters stays the same.

Cons: 
More words.
Attachment #8825975 - Flags: feedback?(dylan)
Screenshot of the proposed change.
Comment on attachment 8825975 [details] [review]
PR 38

I think this is an acceptable change. I'll dkl have the final say though, since he's been working on more UI stuff recently.
Attachment #8825975 - Flags: review?(dkl)
Attachment #8825975 - Flags: feedback?(dylan)
Attachment #8825975 - Flags: feedback+
(In reply to Dylan Hardison [:dylan] from comment #4)
> Comment on attachment 8825975 [details] [review]
> PR 38
> 
> I think this is an acceptable change. I'll dkl have the final say though,
> since he's been working on more UI stuff recently.

I would prefer it to be called 'Edit Bug' because clicking the 'Edit' button enables more than just editing of bug fields. It also allows for toggling privacy on comments, restricting comments, ignoring email for the bug (user specific), etc. Dylan, ok with that too?

dkl
Changed it to "Edit Bug". I'll need to squash the commits before anything lands since there's a bunch of tiny changes.
Squashed and merged. Thanks!
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Due to unforseen need to push to prod early, this is live now.

dkl
Comment on attachment 8825975 [details] [review]
PR 38

Changing to r+ as this went out.

dkl
Attachment #8825975 - Flags: review?(dkl) → review+
Assignee: wkocher → nobody
Component: User Interface: Modal → User Interface
You need to log in before you can comment on or make changes to this bug.