Closed Bug 1330457 Opened 4 years ago Closed 4 years ago

Introduce DocumentAndElementEventHandlers

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Details

Attachments

(1 file)

See https://html.spec.whatwg.org/multipage/webappapis.html#documentandelementeventhandlers

This doesn't really change web-visible behavior; just aligns our IDL more closely with the spec.
Comment on attachment 8826043 [details] [diff] [review]
Introduce DocumentAndElementEventHandlers to more closely align with the HTML spec

Review of attachment 8826043 [details] [diff] [review]:
-----------------------------------------------------------------

Can you point out where the SVGElement spec for these event handlers is?

::: dom/webidl/SVGElement.webidl
@@ +28,5 @@
>    [Throws] void blur();
>  };
>  
>  SVGElement implements GlobalEventHandlers;
> +SVGElement implements DocumentAndElementEventHandlers;

I don't see this in the spec.  Maybe I have the wrong link.  Looking at:

https://svgwg.org/svg2-draft/types.html#InterfaceSVGElement
Attachment #8826043 - Flags: review?(bkelly)
Comment on attachment 8826043 [details] [diff] [review]
Introduce DocumentAndElementEventHandlers to more closely align with the HTML spec

The SVG spec situation here is a mess.  See https://www.w3.org/Graphics/SVG/WG/track/actions/3283 which hasn't happened yet (and is linked from <https://svgwg.org/svg2-draft/interact.html#SVGEvents>), but in general their intent is that the set of event handlers on HTML and SVG elements be identical.
Attachment #8826043 - Flags: review?(bkelly)
Comment on attachment 8826043 [details] [diff] [review]
Introduce DocumentAndElementEventHandlers to more closely align with the HTML spec

Review of attachment 8826043 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.
Attachment #8826043 - Flags: review?(bkelly) → review+
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/426c5f5536bf
Introduce DocumentAndElementEventHandlers to more closely align with the HTML spec.  r=bkelly
https://hg.mozilla.org/mozilla-central/rev/426c5f5536bf
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.