1330457 - Introduce DocumentAndElementEventHandlers

Status: RESOLVED FIXED

Description

[Boris Zbarsky [:bzbarsky, bz on IRC]]

See https://html.spec.whatwg.org/multipage/webappapis.html#documentandelementeventhandlers

This doesn't really change web-visible behavior; just aligns our IDL more closely with the spec.

Comment 1

[Boris Zbarsky [:bzbarsky, bz on IRC]]

Created attachment 8826043 [details] [diff] [review]
Introduce DocumentAndElementEventHandlers to more closely align with the HTML spec

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8826043 [details] [diff] [review]
Introduce DocumentAndElementEventHandlers to more closely align with the HTML spec

Review of attachment 8826043 [details] [diff] [review]:
-----------------------------------------------------------------

Can you point out where the SVGElement spec for these event handlers is?

::: dom/webidl/SVGElement.webidl
@@ +28,5 @@
>    [Throws] void blur();
>  };
>  
>  SVGElement implements GlobalEventHandlers;
> +SVGElement implements DocumentAndElementEventHandlers;

I don't see this in the spec.  Maybe I have the wrong link.  Looking at:

https://svgwg.org/svg2-draft/types.html#InterfaceSVGElement

Comment 3

[Boris Zbarsky [:bzbarsky, bz on IRC]]

Comment on attachment 8826043 [details] [diff] [review]
Introduce DocumentAndElementEventHandlers to more closely align with the HTML spec

The SVG spec situation here is a mess.  See https://www.w3.org/Graphics/SVG/WG/track/actions/3283 which hasn't happened yet (and is linked from <https://svgwg.org/svg2-draft/interact.html#SVGEvents>), but in general their intent is that the set of event handlers on HTML and SVG elements be identical.

Comment 4

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8826043 [details] [diff] [review]
Introduce DocumentAndElementEventHandlers to more closely align with the HTML spec

Review of attachment 8826043 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/426c5f5536bf
Introduce DocumentAndElementEventHandlers to more closely align with the HTML spec.  r=bkelly

Comment 6

[Wes Kocher (:KWierso)]

https://hg.mozilla.org/mozilla-central/rev/426c5f5536bf