Closed Bug 1330476 Opened 3 years ago Closed 3 years ago

configure chain of trust beetmoverscript and balrogscript task definitions in taskgraph

Categories

(Release Engineering :: Release Automation: Other, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jlund, Unassigned)

References

Details

Attachments

(1 file)

No description provided.
so this works as expected against date's https://hg.mozilla.org/projects/date/rev/078e83e4ee1b7e96ee2f14901cba5e91d55d416c

however, yesterday, we removed out the ability to always have a build_platform in attrs:  https://hg.mozilla.org/projects/date/rev/5706c2d6705a411431f28035558e85dd8d50546d

Since my patch assumed the presence of this, I'll have to find an alternative before applying to today's tip. That is, when I have brainz and I can trick mach into pdb'ing when I want it to.
Comment on attachment 8826026 [details]
Bug 1330476 - configure chain of trust beetmoverscript and balrogscript defs in taskgraph,

https://reviewboard.mozilla.org/r/104078/#review104812

::: taskcluster/taskgraph/transforms/beetmover.py:18
(Diff revision 1)
>  )
>  from taskgraph.transforms.task import task_description_schema
>  from voluptuous import Schema, Any, Required, Optional
>  
>  
> +_DESKTOP_UPSTREAM_ARTIFACTS_UNSIGNED_EN_US = [

Let's file a bug to someday have these manifests feed into the build system, like you were wanting for relpro.  We might not be able to tackle it immediately, but it'll be useful to track.

::: taskcluster/taskgraph/transforms/beetmover.py:222
(Diff revision 1)
>              'description': "{} Beetmover".format(
>                  dep_job.task["metadata"]["description"]),
>              # do we have to define worker type somewhere?
>              'worker-type': 'scriptworker-prov-v1/beetmoverworker-v1',
> -            'worker': worker,
> -            'scopes': [],
> +            # bump this to nightly / release when applicable+permitted
> +            'scopes': ["project:releng:beetmover:dep"],

It might be time to bump to nightly as soon as this lands and goes green.  I'm fine with that landing after we green it up, or at the same time.
Comment on attachment 8826026 [details]
Bug 1330476 - configure chain of trust beetmoverscript and balrogscript defs in taskgraph,

Oops, reviewboard ui change?

I think this can land on date (along with a fix for build_platform).  I'm not sure I'm the best reviewer for m-c.
A couple more comments:

* It might be good to chat with Callek about build_platform if you don't find a solution.
* I'm guessing :dustin would have an opinion about the large manifests in the file.  We can also go with flat files or json in external files, and read those in.
* In https://bugzilla.mozilla.org/show_bug.cgi?id=1305139#c2 , Mihai is going to be adding a beetmover task for a checksums file + sig file.  Maybe in make_task_worker there'll be a checksums_kind (in addition to build_kind and signing_kind), and we can use different paths for those.

I definitely underestimated how complex the paths mappings were going to be; thanks for tackling this!
Attachment #8826026 - Flags: review?(aki) → feedback+
https://hg.mozilla.org/projects/date/rev/474dfcafbc730695bbabe3ba418d329a15fffbba
Bug 1330476 - configure chain of trust beetmoverscript and balrogscript defs in taskgraph, r=aki
(In reply to Aki Sasaki [:aki] from comment #3)

> > +_DESKTOP_UPSTREAM_ARTIFACTS_UNSIGNED_EN_US = [
> 
> Let's file a bug to someday have these manifests feed into the build system,
> like you were wanting for relpro.  We might not be able to tackle it
> immediately, but it'll be useful to track.

filed: Bug 1330648 - define a artifact naming manifest that is fed to build system and release automation
See Also: → 1330648
Depends on: 1330650
(In reply to Aki Sasaki [:aki] from comment #4)

> I think this can land on date (along with a fix for build_platform).  I'm
> not sure I'm the best reviewer for m-c.

this is now on date.

> * It might be good to chat with Callek about build_platform if you don't
> find a solution.

turned out to be a red herring and pebkac.

> * I'm guessing :dustin would have an opinion about the large manifests in
> the file.  We can also go with flat files or json in external files, and
> read those in.

sure, I wasn't sure where to put them so I kept them in the same file for now. I believe callek is going to prep all the beet/balrog taskgraph config files now and append this revision on to it.
Blocks: 1330668
Comment on attachment 8826026 [details]
Bug 1330476 - configure chain of trust beetmoverscript and balrogscript defs in taskgraph,

The interdiff looks good.
Attachment #8826026 - Flags: review?(aki) → feedback+
https://hg.mozilla.org/projects/date/rev/ede40b41c114bbe3124e2dde23bb2c3028fc92b0
Bug 1330476 - set beet and balrog scope reqs from dep to nightly, r=me
No longer depends on: 1330650
I believe this is fixed on date, and we have bugs for merging to central.
Resolving; please comment+reopen if this is not accurate.
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.