1330535 - Closing an un-edited message that was created by forwarding or "editing as new" of certain messages displays the dialogue to save/don't save/cancel

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Jorg K (CEST = GMT+2)]

Closing an un-edited message that was created by forwarding or "editing as new" of certain messages displays the dialogue to save/don't save/cancel although the message wasn't changed.

This only happens on certain messages and I haven't been able to work out which.

As a test case use:
mail/test/mozmill/composition/multipart-charset.eml

The bug already shows in TB 45.x, so it's not a recent regression.

Comment 1

[Thomas D. (:thomas8)]

(In reply to Jorg K (GMT+2) from comment #0)
> Closing an un-edited message that was created by forwarding or "editing as
> new" of certain messages displays the dialogue to save/don't save/cancel
> although the message wasn't changed.
> 
> This only happens on certain messages and I haven't been able to work out
> which.

It's messages with attachments, like your testcase below.
Which makes this (as reported) a duplicate of bug 1427617, which is fixed (verified with your testcase message).

Upon composition start, we used to fill the attachment bucket using AddAttachments() function, which always set gContentChanged=true regardless of circumstances.

That said, I think my fix has actually reverted the bug, as I do not agree with comment 0:

* Editing a saved draft works directly on an already saved instance, so if there are no changes to the draft, it's all saved already and there's really nothing new which needs saving (bug 1427617).

* The scenario of comment 0 is different: "Edit as new" uses a random message as a template (which might even get deleted at any time), and creates a NEW (cloned) message from that, and the cloned message has never been saved as a draft. So assuming that user created that new message for a reason (even if it's just a stub), we should ask. Same for "New message from (an actual) template". Word does the same for unsaved new messages created from template with any content; only completely blank documents get discarded without question. This should be filed as a new bug.

As an example, someone might do "Edit as New Message" on last month's report to create this month's report, but he gets distracted before actually editing the new message. So there's a deliberate intention of creating a new draft, and that draft hasn't been saved yet, even just as a to-do in drafts folder. So we must ask. Depending on workflow, last month's report might even be deleted prematurely under the assumption that this month's clone has already been created.

> As a test case use:
> mail/test/mozmill/composition/multipart-charset.eml
> 
> The bug already shows in TB 45.x, so it's not a recent regression.

Comment 2

[Jorg K (CEST = GMT+2)]

Sadly not fixed. I imported mail/test/mozmill/composition/multipart-charset.eml, forwarded, closed the window. The dialog still displays. Have you tested that?

Comment 3

[Jorg K (CEST = GMT+2)]

Umm, now reading comment 1. So apparently the argument is that we should always ask after "edit as new" or forward, right? That appears to be the case now, I can't find a single message whose "clone" can now be saved without the prompt.

If we all agree, then this would be a WONTFIX or INVALID.

Richard, what do you think?

Comment 4

[Jorg K (CEST = GMT+2)]

(In reply to Jorg K (GMT+2) from comment #3)
> Umm, now reading comment 1. So apparently the argument is that we should
> always ask after "edit as new" or forward, right? That appears to be the
> case now, I can't find a single message whose "clone" can now be saved
> without the prompt.
Grrrr, caused by Enigmail :-( - Without Enigmail simple messages forwards can be closed without prompt.

Comment 5

[Jorg K (CEST = GMT+2)]

(In reply to Jorg K (GMT+2) from comment #2)
> Sadly not fixed. I imported
> mail/test/mozmill/composition/multipart-charset.eml, forwarded, closed the
> window. The dialog still displays. Have you tested that?
My sincere apologies, I'm the one who tested that badly.

This is in fact fixed!!

Fixed by bug 1461170 which contained a fix to bug 1427617.

Comment 6

[Thomas D. (:thomas8)]

Imho the correct resolution for this bug is DUPLICATE of bug 1427617 (fixed by bug 1461170), because this bug is just about the *inconsistency* that any messages with attachments used to blanket-prompt ALWAYS where in the same scenario, messages without attachments wouldn't, which is exactly bug 1427617, both for symptoms and fix.

Also so far there is no consensus about the expected behaviour of comment 0, which is still under discussion in bug 1467388, which is another reason why FIXED looks inappropriate here.

Comment 7

[Jorg K (CEST = GMT+2)]

It comes down to taste, I think. My personal rule is: If the summaries show that the issues are related, then a duplicate is fine, otherwise I prefer "fixed by". This bug talks about "edit as new" and forward, the other about drafts.

Anyway, thanks for fixing it, even if you don't agree with the fix ;-)