Animation tooltip says "Easing: linear" even when it's the default / even when keyframe easing is not linear

RESOLVED FIXED in Firefox 54

Status

()

Firefox
Developer Tools: Animation Inspector
P3
enhancement
RESOLVED FIXED
11 months ago
10 months ago

People

(Reporter: birtles, Assigned: birtles)

Tracking

(Blocks: 1 bug)

Trunk
Firefox 54
Points:
---

Firefox Tracking Flags

(firefox53 affected, firefox54 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(4 attachments)

(Assignee)

Description

11 months ago
Created attachment 8826080 [details]
Screenshot

The attached screenshot shows the tooltip for a CSS animation with "animation-timing-function: ease-in". There are two confusing things here:

* It says "Easing: linear" even though the author specifically set a non-linear easing
* Even if the author is clever enough to understand the difference between effect easing and keyframe easing, "linear" is the default for effect easing so this is just noise.

I suggest we:

* Hide this part of the tooltip when the value is "linear"
* When we do show it, call it something like "Effect easing" or "Overall easing". I think I lean towards "Overall easing".

Comment 1

10 months ago
Inspector bug triage (filter on CLIMBING SHOES).
Blocks: 1280937
Severity: normal → enhancement
Priority: -- → P3
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Updated

10 months ago
Assignee: nobody → bbirtles
Status: NEW → ASSIGNED
(Assignee)

Comment 4

10 months ago
Created attachment 8835329 [details]
Screenshot of "Overall easing" tooltip

Not sure if "Overall easing" is too long?

Comment 5

10 months ago
mozreview-review
Comment on attachment 8835327 [details]
Bug 1330538 - Hide easing label in tooltip when the easing is linear (the default);

https://reviewboard.mozilla.org/r/111018/#review112288

Thank you Brian!

Also for the consistency, we may be better to change 'fill' mode as well in another bug.
(Currently, if I set 'none' for the fill mode, displayed the 'none'.)
Attachment #8835327 - Flags: review?(dakatsuka) → review+

Comment 6

10 months ago
mozreview-review
Comment on attachment 8835328 [details]
Bug 1330538 - Rename 'Easing:' to 'Overall easing:';

https://reviewboard.mozilla.org/r/111020/#review112390

Overall easing sounds fine to me. Thanks Brian.
Attachment #8835328 - Flags: review?(pbrosset) → review+

Comment 7

10 months ago
Pushed by bbirtles@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1d525c02a7ca
Hide easing label in tooltip when the easing is linear (the default); r=daisuke
https://hg.mozilla.org/integration/autoland/rev/88dd8d9bcd9d
Rename 'Easing:' to 'Overall easing:'; r=pbro

Comment 8

10 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/1d525c02a7ca
https://hg.mozilla.org/mozilla-central/rev/88dd8d9bcd9d
Status: ASSIGNED → RESOLVED
Last Resolved: 10 months ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
You need to log in before you can comment on or make changes to this bug.