1330603 - Remove MDSM::CheckIfDecodeComplete()

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1330603. Part 1 - remove the call to CheckIfDecodeComplete() from HandleEndOf{Audio,Video}.

1. in HandleEndOfAudio, we surely have !IsAudioDecoding(). So we only need to check !IsVideoDecoding().
2. likewise, we only need to check !IsAudioDecoding() in HandleEndOfVideo().

Review commit: https://reviewboard.mozilla.org/r/104158/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/104158/

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1330603. Part 2 - remove MDSM::CheckIfDecodeComplete().

Review commit: https://reviewboard.mozilla.org/r/104160/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/104160/

Comment 3

[Tzuhao Kuo [:kaku]]

Comment on attachment 8826141 [details]
Bug 1330603. Part 1 - remove the call to CheckIfDecodeComplete() from HandleEndOf{Audio,Video}.

https://reviewboard.mozilla.org/r/104158/#review105112

Comment 4

[Tzuhao Kuo [:kaku]]

Comment on attachment 8826142 [details]
Bug 1330603. Part 2 - remove MDSM::CheckIfDecodeComplete().

https://reviewboard.mozilla.org/r/104160/#review105114

Comment 5

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e3e5a501fbca
Part 1 - remove the call to CheckIfDecodeComplete() from HandleEndOf{Audio,Video}. r=kaku
https://hg.mozilla.org/integration/autoland/rev/b8970b27c10e
Part 2 - remove MDSM::CheckIfDecodeComplete(). r=kaku

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e3e5a501fbca
https://hg.mozilla.org/mozilla-central/rev/b8970b27c10e