1330614 - [Static Analysis][Resource Leak] In function FillRectWithMask

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Andi [:andi]]

The Static Analysis tool Coverity detected that a memory leak would happen in the following context:

>>    size_t size = mr->RecordingSize();
>>    char* buffer = new char[size];
>>    mr->CopyRecording(buffer, size);
>>    std::istringstream recording(std::string(buffer, size));
>>
>>    translator->TranslateRecording(recording);
>>
>>    aDT->SetTransform(oldTransform);
>>    aDT->PopClip();
>>    return;

Since buffer is not cached it should be removed.

Comment 1

[Andi [:andi]]

Attachment: Bug 1330614 - avoid memory leak in FillRectWithMask.

Review commit: https://reviewboard.mozilla.org/r/104176/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/104176/

Comment 2

[Andi [:andi]]

Comment on attachment 8826158 [details]
Bug 1330614 - avoid memory leak in FillRectWithMask.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/104176/diff/1-2/

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8826158 [details]
Bug 1330614 - avoid memory leak in FillRectWithMask.

https://reviewboard.mozilla.org/r/104176/#review104930

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cd0c259fde48
avoid memory leak in FillRectWithMask. r=jrmuizel

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/cd0c259fde48