URLSearchParams constructor is not supported by our webidl codegen

RESOLVED FIXED

Status

()

Core
DOM
P3
normal
RESOLVED FIXED
11 months ago
9 months ago

People

(Reporter: baku, Unassigned)

Tracking

50 Branch
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox54 fixed)

Details

(Reporter)

Description

11 months ago
Recently URLSearchParams CTOR is changed:

[Constructor(optional (sequence<sequence<USVString>> or record<USVString, USVString> or USVString) init = ""), ...

but record is not supported, and also without it, 'Constructor(optional (sequence<sequence<USVString>> or USVString) init = "")' gives syntax error.
(Reporter)

Updated

11 months ago
Flags: needinfo?(bzbarsky)
record is kinda supported as MozMap.  But it doesn't have quite the same semantics (e.g. is not order-preserving).  We should probably modify MozMap to be named "record" and change its implementation to match the spec.

> and also without it, 'Constructor(optional (sequence<sequence<USVString>> or USVString) init = "")'
> gives syntax error

I don't get a syntax error here.  I do get a codegen error because we don't support USVString as the type of the default value in handleDefaultStringValue.  That should be pretty simple to fix.
Flags: needinfo?(bzbarsky)
(Reporter)

Updated

11 months ago
Depends on: 1330698
(Reporter)

Updated

11 months ago
Depends on: 1330699

Updated

11 months ago
Priority: -- → P3
When you add this, please add a test that the _key_ values are getting the USVString treatment.
Long since fixed when the dependencies got fixed.
Status: NEW → RESOLVED
Last Resolved: 9 months ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.