verify xperf_whitelist.json entries are still needed

RESOLVED FIXED in Firefox 54

Status

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jmaher, Assigned: jmaher)

Tracking

Trunk
mozilla54
Points:
---

Firefox Tracking Flags

(firefox54 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

right now we have a long laundry list of files that we expect to be accessed on startup (measured by the windows xperf talos test):
https://dxr.mozilla.org/mozilla-central/source/testing/talos/talos/xtalos/xperf_whitelist.json?q=path%3Axperf_whitelist.json&redirect_type=single#16

I suspect some of these files are not needed anymore, keeping this list up to date would be important.

we also have mainthreadIO fileIO measurements in this file:
https://dxr.mozilla.org/mozilla-central/source/testing/talos/talos/mtio-whitelist.json

again, keeping that list up to date (i.e. removing old entries) seems important.

as a note, sometimes things are intermittent or pgo only (bug 1324062, comment 79)
Posted patch xperf_sanity.patch (obsolete) — Splinter Review
remove some obvious xperf_whitelist.json entries.

a failure case here:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=8008b1bb89bc7a402728f460ea2382d7c3f62ac8

adding those missing ones back in here:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=20cc8bc16b8a9bdc55776affd8b3f6937af1fd9e
Assignee: nobody → jmaher
Status: NEW → ASSIGNED
Attachment #8826280 - Flags: review?(rwood)
Comment on attachment 8826280 [details] [diff] [review]
xperf_sanity.patch

LGTM, R+ pending green on try
Attachment #8826280 - Flags: review?(rwood) → review+
Pushed by jmaher@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e8ae38b46276
remove old xperf_whitelist.json entries. r=rwood
I had mentioned mainthread_io, I had removed almost all the entries in a try server push and we are not detecting anything- possibly this isn't running anymore.
as a note, I removed what I thought would be easy to remove, possibly other files could be removed, although I believe it would be better served in the future as an annual cleanup.
I had to back this out because some Windows pgo xperf runs failed with it in: https://treeherder.mozilla.org/logviewer.html#?job_id=68825854&repo=mozilla-inbound

https://hg.mozilla.org/integration/mozilla-inbound/rev/4ef05cc6af4e
Flags: needinfo?(jmaher)
thanks for backing this out, I am testing a patch on pgo and non pgo to validate all is well.  it looks like a small chunk of my removals are needed.
Flags: needinfo?(jmaher)
lets try this again, now I made sure to test on pgo before calling this good.  Removed some old entries, put things in a more logical order, and added some new entries (for intermittent issues)
Attachment #8826280 - Attachment is obsolete: true
Attachment #8829207 - Flags: review?(rwood)
Comment on attachment 8829207 [details] [diff] [review]
cleanup old xperf whitelist file

LGTM
Attachment #8829207 - Flags: review?(rwood) → review+
Pushed by jmaher@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e0f2dbc7c3cb
verify xperf_whitelist.json entries are still needed. r=rwood
https://hg.mozilla.org/mozilla-central/rev/e0f2dbc7c3cb
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.