1330734 - Support embedded dwrite bitmap fonts in webrender

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P1)

Description

[Mason Chang [Inactive] [:mchang]]

http://searchfox.org/mozilla-central/source/gfx/2d/DrawTargetSkia.cpp#1391

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Can you elaborate on this? The link in comment 0 is obsolete.

Comment 2

[Mason Chang [Inactive] [:mchang]]

We have a flag aUseEmbeddedBitmap[1], which is passed along to Skia to [2][4]. This should be the same as piping in the GDI font information [3]

[1] http://searchfox.org/mozilla-central/rev/5e1e8d2f244bd8c210a578ff1f65c3b720efe34e/gfx/2d/Factory.cpp#869
[2] http://searchfox.org/mozilla-central/rev/5e1e8d2f244bd8c210a578ff1f65c3b720efe34e/gfx/skia/skia/src/ports/SkScalerContext_win_dw.cpp#262
[3] https://github.com/servo/webrender/blob/master/webrender/src/platform/windows/font.rs#L295
[4] http://searchfox.org/mozilla-central/source/gfx/2d/DrawTargetSkia.cpp#1431

Comment 3

[Milan Sreckovic [:milan] (needinfo for best results)]

How common are these?  Can we make this stage-wr-next?

Comment 4

[tjtncks]

As Major sites in South Korea still uses bitmap fonts like Gulim or Dotum, (like on https://www.naver.com ,which uses Dotum for small fonts. I wish it has higher priority.

And Gulim and Dotum fonts are only included in Korean language pack in windows 10, you won't see it unless you install korean language pack. (it will defalut back to ... Malgun Gothic? I think)

Comment 5

[tjtncks]

Attachment: Screenshot-2017-11-7 네이버(1).png

Comment 6

[Jeff Muizelaar [:jrmuizel]]

Indeed. tjtncks can you file a separate bug for that issue?

Comment 7

[Jeff Muizelaar [:jrmuizel]]

Oh, sorry this is the right bug. I thought this was the SVG bug :)

Comment 8

[Jeff Muizelaar [:jrmuizel]]

Lee, what's needed to make this work?

Comment 9

[Lee Salzman [:lsalzman]]

(In reply to Jeff Muizelaar [:jrmuizel] from comment #8)
> Lee, what's needed to make this work?

WR PR https://github.com/servo/webrender/pull/2038

Comment 10

[Lee Salzman [:lsalzman]]

(In reply to tjtncks from comment #4)
> As Major sites in South Korea still uses bitmap fonts like Gulim or Dotum,
> (like on https://www.naver.com ,which uses Dotum for small fonts. I wish it
> has higher priority.
> 
> And Gulim and Dotum fonts are only included in Korean language pack in
> windows 10, you won't see it unless you install korean language pack. (it
> will defalut back to ... Malgun Gothic? I think)

Is this now fixed in the latest nightly build?

Comment 11

[tjtncks]

(In reply to Lee Salzman [:lsalzman] from comment #10)
> (In reply to tjtncks from comment #4)
> > As Major sites in South Korea still uses bitmap fonts like Gulim or Dotum,
> > (like on https://www.naver.com ,which uses Dotum for small fonts. I wish it
> > has higher priority.
> > 
> > And Gulim and Dotum fonts are only included in Korean language pack in
> > windows 10, you won't see it unless you install korean language pack. (it
> > will defalut back to ... Malgun Gothic? I think)
> 
> Is this now fixed in the latest nightly build?

It does, (actually , it's been one or two days) but fakebold it not supported (it's get a pixel wider, but that's all.)
https://bugzilla.mozilla.org/show_bug.cgi?id=1418564