Closed Bug 1330791 Opened 8 years ago Closed 8 years ago

Enable a few more eslint rules for /services

Categories

(Cloud Services :: General, defect)

Product:
Cloud Services
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox53 fixed)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox53 --- fixed

People

(Reporter: jaws, Assigned: jaws)

Details

Attachments

(14 files, 2 obsolete files)

Bug 1330791 - Enable the no-unused-vars rule for eslint in /services and fix associated errors.
59 bytes, text/x-review-board-request
markh
: review+
Details
Bug 1330791 - Enable the no-useless-call eslint rule for /services and fix associated errors.
59 bytes, text/x-review-board-request
markh
: review+
Details
Bug 1330791 - Enable the no-empty rule for eslint. There were no associated errors with this rule.
59 bytes, text/x-review-board-request
markh
: review+
Details
Bug 1330791 - Enable no-else-return rule for eslint in /services and fix associated errors.
59 bytes, text/x-review-board-request
markh
: review+
Details
Bug 1330791 - Enable the no-unsafe-finally rule for eslint in /services. There are no associated errors with this rule.
59 bytes, text/x-review-board-request
markh
: review+
Details
Bug 1330791 - Enable the no-unreachable rule for eslint in /services and fix the associated errors.
59 bytes, text/x-review-board-request
markh
: review+
Details
Bug 1330791 - Enable the no-redeclare rule for eslint in /services and fix the associated errors.
59 bytes, text/x-review-board-request
markh
: review+
Details
Bug 1330791 - Enable the no-octal rule for eslint and fix the associated error.
59 bytes, text/x-review-board-request
markh
: review+
Details
Bug 1330791 - Enable the brace-style rule for eslint in /services and fix the associated errors.
59 bytes, text/x-review-board-request
markh
: review+
Details
Bug 1330791 - Enable the no-cond-assign rule for eslint in /services. There are no associated errors with enabling this rule.
59 bytes, text/x-review-board-request
markh
: review+
Details
Bug 1330791 - Enable the no-ex-assign rule for eslint in /services. There are no associated errors with enabling this rule.
59 bytes, text/x-review-board-request
markh
: review+
Details
Bug 1330791 - Enable the no-native-reassign rule for eslint in /services and fix the associated error.
59 bytes, text/x-review-board-request
markh
: review+
Details
Bug 1330791 - Enable the no-mixed-spaces-and-tabs rule and fix the associated errors.
59 bytes, text/x-review-board-request
markh
: review+
Details
Bug 1330791 - Enable the no-irregular-whitespace rule for /services and fix the associated errors.
59 bytes, text/x-review-board-request
markh
: review+
Details
Bug 1330014 added eslint support for /services, but turned the remaining errors in to warnings temporarily. This bug should fix most of those errors.
Summary: Enable a few more eslint rules → Enable a few more eslint rules for /services
Comment on attachment 8826369 [details] Bug 1330791 - Enable the no-mixed-spaces-and-tabs rule and fix the associated errors. https://reviewboard.mozilla.org/r/104304/#review105478
Attachment #8826369 - Flags: review?(markh) → review+
Comment on attachment 8826370 [details] Bug 1330791 - Enable the no-irregular-whitespace rule for /services and fix the associated errors. https://reviewboard.mozilla.org/r/104306/#review105480
Attachment #8826370 - Flags: review?(markh) → review+
Comment on attachment 8826371 [details] Bug 1330791 - Enable the no-unused-vars rule for eslint in /services and fix associated errors. https://reviewboard.mozilla.org/r/104308/#review105482 ::: services/common/modules-testing/storageserver.js:348 (Diff revision 1) > * > * @return an array of ServerBSOs. > */ > bsos: function bsos(filter) { > let os = []; > - for (let [id, bso] of Object.entries(this._bsos)) { > + for (let [, bso] of Object.entries(this._bsos)) { Object.values? ::: services/common/modules-testing/storageserver.js:443 (Diff revision 1) > }, > > count: function count(options) { > options = options || {}; > let c = 0; > - for (let [id, bso] of Object.entries(this._bsos)) { > + for (let [, bso] of Object.entries(this._bsos)) { Object.values? ::: services/common/modules-testing/storageserver.js:601 (Diff revision 1) > if (options.ids && options.ids.length > this.BATCH_MAX_COUNT) { > throw HTTP_400; > } > > let deleted = []; > - for (let [id, bso] of Object.entries(this._bsos)) { > + for (let [, bso] of Object.entries(this._bsos)) { Object.values? ::: services/fxaccounts/FxAccounts.jsm:745 (Diff revision 1) > }, > > _destroyAllOAuthTokens(tokenInfos) { > // let's just destroy them all in parallel... > let promises = []; > - for (let [key, tokenInfo] of Object.entries(tokenInfos || {})) { > + for (let [, tokenInfo] of Object.entries(tokenInfos || {})) { Object.values? ::: services/sync/modules/SyncedTabs.jsm:115 (Diff revision 1) > > let seenURLs = new Set(); > - let parentIndex = 0; > let ntabs = 0; > > - for (let [guid, client] of Object.entries(engine.getAllClients())) { > + for (let [, client] of Object.entries(engine.getAllClients())) { Object.values? ::: services/sync/modules/resource.js:166 (Diff revision 1) > } > } else { > this._log.debug("No authenticator found."); > } > > - for (let [key, value] of Object.entries(headers)) { > + for (let [key, ] of Object.entries(headers)) { Object.values? ::: services/sync/tests/unit/head_http_server.js:202 (Diff revision 1) > * > * @return an array of ServerWBOs. > */ > wbos: function wbos(filter) { > let os = []; > - for (let [id, wbo] of Object.entries(this._wbos)) { > + for (let [, wbo] of Object.entries(this._wbos)) { Object.values? (and the next 3 changes in this file)
Attachment #8826371 - Flags: review?(markh) → review+
Comment on attachment 8826372 [details] Bug 1330791 - Enable the no-useless-call eslint rule for /services and fix associated errors. https://reviewboard.mozilla.org/r/104310/#review105486
Attachment #8826372 - Flags: review?(markh) → review+
Comment on attachment 8826373 [details] Bug 1330791 - Enable the no-empty rule for eslint. There were no associated errors with this rule. https://reviewboard.mozilla.org/r/104312/#review105488
Attachment #8826373 - Flags: review?(markh) → review+
Comment on attachment 8826374 [details] Bug 1330791 - Enable no-else-return rule for eslint in /services and fix associated errors. https://reviewboard.mozilla.org/r/104314/#review105490
Attachment #8826374 - Flags: review?(markh) → review+
Comment on attachment 8826375 [details] Bug 1330791 - Enable the no-unsafe-finally rule for eslint in /services. There are no associated errors with this rule. https://reviewboard.mozilla.org/r/104316/#review105492
Attachment #8826375 - Flags: review?(markh) → review+
Comment on attachment 8826376 [details] Bug 1330791 - Enable the no-unreachable rule for eslint in /services and fix the associated errors. https://reviewboard.mozilla.org/r/104318/#review105494
Attachment #8826376 - Flags: review?(markh) → review+
Comment on attachment 8826377 [details] Bug 1330791 - Enable the no-redeclare rule for eslint in /services and fix the associated errors. https://reviewboard.mozilla.org/r/104320/#review105496
Attachment #8826377 - Flags: review?(markh) → review+
Comment on attachment 8826378 [details] Bug 1330791 - Enable the no-octal rule for eslint and fix the associated error. https://reviewboard.mozilla.org/r/104322/#review105498
Attachment #8826378 - Flags: review?(markh) → review+
Comment on attachment 8826379 [details] Bug 1330791 - Enable the brace-style rule for eslint in /services and fix the associated errors. https://reviewboard.mozilla.org/r/104324/#review105500
Attachment #8826379 - Flags: review?(markh) → review+
Comment on attachment 8826380 [details] Bug 1330791 - Enable the no-cond-assign rule for eslint in /services. There are no associated errors with enabling this rule. https://reviewboard.mozilla.org/r/104326/#review105502
Attachment #8826380 - Flags: review?(markh) → review+
Comment on attachment 8826381 [details] Bug 1330791 - Enable the no-ex-assign rule for eslint in /services. There are no associated errors with enabling this rule. https://reviewboard.mozilla.org/r/104328/#review105504
Attachment #8826381 - Flags: review?(markh) → review+
Comment on attachment 8826382 [details] Bug 1330791 - Enable the no-native-reassign rule for eslint in /services and fix the associated error. https://reviewboard.mozilla.org/r/104330/#review105506 Wow - thanks Jaws!
Attachment #8826382 - Flags: review?(markh) → review+
Pushed by jwein@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/631adda26a21 Enable the no-mixed-spaces-and-tabs rule and fix the associated errors. r=markh https://hg.mozilla.org/integration/autoland/rev/610ec89e98bb Enable the no-irregular-whitespace rule for /services and fix the associated errors. r=markh https://hg.mozilla.org/integration/autoland/rev/5b2b2be2e389 Enable the no-unused-vars rule for eslint in /services and fix associated errors. r=markh https://hg.mozilla.org/integration/autoland/rev/4902107b7568 Enable the no-useless-call eslint rule for /services and fix associated errors. r=markh https://hg.mozilla.org/integration/autoland/rev/a5fe483288db Enable the no-empty rule for eslint. There were no associated errors with this rule. r=markh https://hg.mozilla.org/integration/autoland/rev/ef7356099bd3 Enable no-else-return rule for eslint in /services and fix associated errors. r=markh https://hg.mozilla.org/integration/autoland/rev/46f9c247550d Enable the no-unsafe-finally rule for eslint in /services. There are no associated errors with this rule. r=markh https://hg.mozilla.org/integration/autoland/rev/25a6356de622 Enable the no-unreachable rule for eslint in /services and fix the associated errors. r=markh https://hg.mozilla.org/integration/autoland/rev/b35cbfcd801f Enable the no-redeclare rule for eslint in /services and fix the associated errors. r=markh https://hg.mozilla.org/integration/autoland/rev/53d4b83ccd22 Enable the no-octal rule for eslint and fix the associated error. r=markh https://hg.mozilla.org/integration/autoland/rev/49d8016fab12 Enable the brace-style rule for eslint in /services and fix the associated errors. r=markh https://hg.mozilla.org/integration/autoland/rev/e0cbc754e841 Enable the no-cond-assign rule for eslint in /services. There are no associated errors with enabling this rule. r=markh https://hg.mozilla.org/integration/autoland/rev/a3c656a9f3ca Enable the no-ex-assign rule for eslint in /services. There are no associated errors with enabling this rule. r=markh https://hg.mozilla.org/integration/autoland/rev/eada8de7256f Enable the no-native-reassign rule for eslint in /services and fix the associated error. r=markh
General theme of the failures seems to be "ReferenceError: quanta is not defined at resource://services-common/utils.js:244", which would be this patch: https://hg.mozilla.org/integration/autoland/rev/5b2b2be2e389d364a58a8c8356e1913edeeb34b1#l15.12
(In reply to Wes Kocher (:KWierso) from comment #59) > General theme of the failures seems to be "ReferenceError: quanta is not > defined at resource://services-common/utils.js:244", which would be this > patch: > > https://hg.mozilla.org/integration/autoland/rev/ > 5b2b2be2e389d364a58a8c8356e1913edeeb34b1#l15.12 Thank you for tracking this down!
Flags: needinfo?(jaws)
Attachment #8826369 - Attachment is obsolete: true
Attachment #8826370 - Attachment is obsolete: true
Comment on attachment 8828417 [details] Bug 1330791 - Enable the no-mixed-spaces-and-tabs rule and fix the associated errors. https://reviewboard.mozilla.org/r/105834/#review106848
Attachment #8828417 - Flags: review?(markh) → review+
Comment on attachment 8828418 [details] Bug 1330791 - Enable the no-irregular-whitespace rule for /services and fix the associated errors. https://reviewboard.mozilla.org/r/105836/#review106850
Attachment #8828418 - Flags: review?(markh) → review+
Pushed by jwein@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6caa811ef3d7 Enable the no-mixed-spaces-and-tabs rule and fix the associated errors. r=markh https://hg.mozilla.org/integration/autoland/rev/e7eb16354b01 Enable the no-irregular-whitespace rule for /services and fix the associated errors. r=markh https://hg.mozilla.org/integration/autoland/rev/10ffcb6f4a6c Enable the no-unused-vars rule for eslint in /services and fix associated errors. r=markh https://hg.mozilla.org/integration/autoland/rev/3e70e0b7f07b Enable the no-useless-call eslint rule for /services and fix associated errors. r=markh https://hg.mozilla.org/integration/autoland/rev/83aebfdeb005 Enable the no-empty rule for eslint. There were no associated errors with this rule. r=markh https://hg.mozilla.org/integration/autoland/rev/5e9e3e81dc81 Enable no-else-return rule for eslint in /services and fix associated errors. r=markh https://hg.mozilla.org/integration/autoland/rev/2d05b9324d10 Enable the no-unsafe-finally rule for eslint in /services. There are no associated errors with this rule. r=markh https://hg.mozilla.org/integration/autoland/rev/b56d2b149310 Enable the no-unreachable rule for eslint in /services and fix the associated errors. r=markh https://hg.mozilla.org/integration/autoland/rev/d22ec67cd6d6 Enable the no-redeclare rule for eslint in /services and fix the associated errors. r=markh https://hg.mozilla.org/integration/autoland/rev/51db4bf68e5d Enable the no-octal rule for eslint and fix the associated error. r=markh https://hg.mozilla.org/integration/autoland/rev/f0d2fdb10650 Enable the brace-style rule for eslint in /services and fix the associated errors. r=markh https://hg.mozilla.org/integration/autoland/rev/24d934bf2cb5 Enable the no-cond-assign rule for eslint in /services. There are no associated errors with enabling this rule. r=markh https://hg.mozilla.org/integration/autoland/rev/ec582d270128 Enable the no-ex-assign rule for eslint in /services. There are no associated errors with enabling this rule. r=markh https://hg.mozilla.org/integration/autoland/rev/3e1c799eb6f6 Enable the no-native-reassign rule for eslint in /services and fix the associated error. r=markh
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: