Closed Bug 1330818 Opened 3 years ago Closed 3 years ago

base URLs broken in windowcreator test

Categories

(Core Graveyard :: Embedding: APIs, defect)

defect
Not set

Tracking

(firefox53 fixed)

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: myk, Assigned: myk)

References

Details

Attachments

(1 file)

Bug 1309049 broke loading of a test page in toolkit/components/windowcreator/test/browser_bug1204626.js (although the test still passes), as the URL bases still reference the embedding/ directory.  Here's the fix.
Attachment #8826387 - Flags: review?(dtownsend)
Attachment #8826387 - Flags: review?(dtownsend) → review+
Depends on: 1309049
Pushed by myk@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8cf18e375fde
update base URLs in windowcreator test, r=mossop
(In reply to Myk Melez [:myk] [@mykmelez] from comment #0)
> Bug 1309049 broke loading of a test page in
> toolkit/components/windowcreator/test/browser_bug1204626.js (although the
> test still passes), as the URL bases still reference the embedding/
> directory.  Here's the fix.

Is it possible to make the test fail when the directory is changed again?
https://hg.mozilla.org/mozilla-central/rev/8cf18e375fde
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
(In reply to Masatoshi Kimura [:emk] from comment #2)
> (In reply to Myk Melez [:myk] [@mykmelez] from comment #0)
> > Bug 1309049 broke loading of a test page in
> > toolkit/components/windowcreator/test/browser_bug1204626.js (although the
> > test still passes), as the URL bases still reference the embedding/
> > directory.  Here's the fix.
> 
> Is it possible to make the test fail when the directory is changed again?

I'm unsure.  The test uses BrowserTestUtils.openNewForegroundTab, which resolves its promise after opening the tab and loading a URL in it, whether or not that URL is found on the test server.  I suppose it could be made to reject the promise if the URL isn't found, although there may be tests that rely on the ability to load such URLs.
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.