1330818 - base URLs broken in windowcreator test

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: APIs, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

Attachment: update base URLs in windowcreator test

Bug 1309049 broke loading of a test page in toolkit/components/windowcreator/test/browser_bug1204626.js (although the test still passes), as the URL bases still reference the embedding/ directory.  Here's the fix.

Comment 1

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8cf18e375fde
update base URLs in windowcreator test, r=mossop

Comment 2

[Masatoshi Kimura [:emk]]

(In reply to Myk Melez [:myk] [@mykmelez] from comment #0)
> Bug 1309049 broke loading of a test page in
> toolkit/components/windowcreator/test/browser_bug1204626.js (although the
> test still passes), as the URL bases still reference the embedding/
> directory.  Here's the fix.

Is it possible to make the test fail when the directory is changed again?

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8cf18e375fde

Comment 4

[Myk Melez [:myk] [@mykmelez]]

(In reply to Masatoshi Kimura [:emk] from comment #2)
> (In reply to Myk Melez [:myk] [@mykmelez] from comment #0)
> > Bug 1309049 broke loading of a test page in
> > toolkit/components/windowcreator/test/browser_bug1204626.js (although the
> > test still passes), as the URL bases still reference the embedding/
> > directory.  Here's the fix.
> 
> Is it possible to make the test fail when the directory is changed again?

I'm unsure.  The test uses BrowserTestUtils.openNewForegroundTab, which resolves its promise after opening the tab and loading a URL in it, whether or not that URL is found on the test server.  I suppose it could be made to reject the promise if the URL isn't found, although there may be tests that rely on the ability to load such URLs.