Change CSS pre-processor to Sass

RESOLVED FIXED

Status

developer.mozilla.org
Code Cleanup
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: shobson, Assigned: shobson)

Tracking

Details

(Assignee)

Description

a year ago
Let's use the CSS pre processor with the best support, documentation, community, and tools.
(Assignee)

Updated

a year ago
Assignee: nobody → shobson

Comment 1

a year ago
Commit pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/7b7b608ff3e68ef5b3d645919b178047036b6c1c
bug 1330838: Add node-sass to base image (#4111)

Get node-sass into the base image, so the quick tests (locales in
TravisCI, tests in Jenkins) will pass for PR #4109.

Comment 2

a year ago
Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/9854276301ccabbfdb3086867cf866620dd6e725
bug 1330838: Set pipeline to prod mode in test

When running tests, set django-pipeline and staticfiles to "production"
mode, where they assume ./manage.py collectstatic has been run and do
not do extra work. This is the default when DEBUG=False, but our
settings files setup pipeline while DEBUG=True.

https://github.com/mozilla/kuma/commit/52b270965b4991554d7500c27eab72a5b7fd32af
Merge pull request #4109 from mozilla/1330838-sass-experiment

bug 1330838: change css pre-processor to sass
Deployed to stage, production, and docker environments.  It has been merged into the pipeline process, and there are now instructions for using gulp to efficiently rebuild for changes.
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
See Also: → bug 1335663
See Also: → bug 1335671
(Assignee)

Comment 4

a year ago
\o/

Comment 5

a year ago
Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/276444e973f7c6b8cca4fff87520ce0637077f84
bug 1330838: Complete report on pipeline settings

Complete the report on the effect of pipeline settings on test execution
speed from PR #4109.

https://github.com/mozilla/kuma/commit/16aee6cdfbe960cd50b8cdf4849106a7c1724f14
Merge pull request #4112 from jwhitlock/pipeline_science_1330838

bug 1330838: Complete report on pipeline settings

Comment 6

a year ago
Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/3cf4bf068d0ffdf92e92007f6afdeb53c0d16e96
bug 1330838: Raise exceptions on pipeline errors

The Jinja2 PipelineExtension can't render error CSS:

https://github.com/jazzband/django-pipeline/issues/614

https://github.com/mozilla/kuma/commit/4476017f54ff40217d55c8145c924f9cfed6be9d
Merge pull request #4117 from jwhitlock/pipeline_errors_1330838

bug 1330838: Raise exceptions on pipeline errors
You need to log in before you can comment on or make changes to this bug.