1330844 - Gogo In-Flight Wifi purchase page credit card field is filled/saved by password manager

Status: RESOLVED FIXED

(Toolkit :: Password Manager: Site Compatibility, defect)

Description

[Matthew N. [:MattN]]

Attachment: Screen Shot

Gogo's in-flight wifi purchase page has form to login with a Gogo account but also uses type=password for the credit card field so saved gogo logins get filled into the card name and card number fields on this page (which is incorrect).

A recipe to not consider the #cardNumber field as a password field will stop password manager from interfering with these two fields.

Comment 1

[Matthew N. [:MattN]]

Attachment: Bug 1330844 - Add a pwmgr notPasswordSelector:#cardNumber recipe for buy.gogoinflight.com.

Review commit: https://reviewboard.mozilla.org/r/104384/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/104384/

Comment 2

[Johann Hofmann [:johannh]]

Comment on attachment 8826438 [details]
Bug 1330844 - Add a pwmgr notPasswordSelector:#cardNumber recipe for buy.gogoinflight.com.

https://reviewboard.mozilla.org/r/104384/#review105130

Looks good, thanks. I obviously couldn't test this as I'm not on an airplane right now.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/015e226bec04
Add a pwmgr notPasswordSelector:#cardNumber recipe for buy.gogoinflight.com. r=johannh

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/015e226bec04