Closed Bug 1330889 Opened 4 years ago Closed 4 years ago

Remove some mState checks from MediaDecoderStateMachine

Categories

(Core :: Audio/Video: Playback, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

Details

Attachments

(5 files)

No description provided.
Assignee: nobody → jwwang
Blocks: 1324999
Priority: -- → P3
Attachment #8826534 - Flags: review?(kikuo)
Attachment #8826535 - Flags: review?(kikuo)
Attachment #8826536 - Flags: review?(kikuo)
Attachment #8826537 - Flags: review?(kikuo)
Attachment #8826538 - Flags: review?(kikuo)
Comment on attachment 8826534 [details]
Bug 1330889. Part 1 - remove the assertion in MDSM::FinishShutdown.

https://reviewboard.mozilla.org/r/104486/#review105612
Attachment #8826534 - Flags: review?(kikuo) → review+
Comment on attachment 8826535 [details]
Bug 1330889. Part 2 - remove some mState checks from MDSM::ResetDecode.

https://reviewboard.mozilla.org/r/104488/#review105618
Attachment #8826535 - Flags: review?(kikuo) → review+
Comment on attachment 8826536 [details]
Bug 1330889. Part 3 - remove the mState check from HasLowBufferedData().

https://reviewboard.mozilla.org/r/104490/#review105630
Attachment #8826536 - Flags: review?(kikuo) → review+
Comment on attachment 8826537 [details]
Bug 1330889. Part 4 - remove the mState checks from MaybeStartPlayback().

https://reviewboard.mozilla.org/r/104492/#review105638
Attachment #8826537 - Flags: review?(kikuo) → review+
Comment on attachment 8826538 [details]
Bug 1330889. Part 5 - remove MDSM::mState.

https://reviewboard.mozilla.org/r/104494/#review105642
Attachment #8826538 - Flags: review?(kikuo) → review+
Thanks!
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/359372e06f84
Part 1 - remove the assertion in MDSM::FinishShutdown. r=kikuo
https://hg.mozilla.org/integration/autoland/rev/befabe73c225
Part 2 - remove some mState checks from MDSM::ResetDecode. r=kikuo
https://hg.mozilla.org/integration/autoland/rev/4971ca440d80
Part 3 - remove the mState check from HasLowBufferedData(). r=kikuo
https://hg.mozilla.org/integration/autoland/rev/9584a95515b3
Part 4 - remove the mState checks from MaybeStartPlayback(). r=kikuo
https://hg.mozilla.org/integration/autoland/rev/e4de8d9250ac
Part 5 - remove MDSM::mState. r=kikuo
You need to log in before you can comment on or make changes to this bug.