Closed Bug 1330947 Opened 7 years ago Closed 7 years ago

Link mintrayr with libxul after binary components have been removed

Categories

(Instantbird Graveyard :: Other, defect)

Product:
Instantbird Graveyard
Component:
Other
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Instantbird 53

People

(Reporter: clokep, Assigned: clokep)

References

Details

Attachments

(1 file, 1 obsolete file)

mintrayr-fix.diff v2
1.86 KB, patch
clokep
: review+
Details | Diff | Splinter Review
Attached patch mintrayr-fix.diff (obsolete) — — Splinter Review 
Windows building is busted due to being unable to build mintrayr since external binary components are no longer allowed.
Attachment #8826558 - Flags: review?(aleth)
I was able to complete a Windows build with this patch and ensured that the tray functionality worked.
Assignee: nobody → clokep
Severity: normal → critical
Status: NEW → ASSIGNED
Depends on: 1314955
Summary: Fix build bustage in mintrayr around external binary components → Link mintrayr with libxul after binary components have been removed
Attachment #8826558 - Flags: review?(florian)
Comment on attachment 8826558 [details] [diff] [review]
mintrayr-fix.diff

Looks reasonable.
Attachment #8826558 - Flags: review?(florian) → review+
Thanks! While talking on IRC we decided to try without the call to `Library`. Trying that now.
Carrying forward the r+. This worked fine without the Library() call.
Attachment #8826558 - Attachment is obsolete: true
Attachment #8826558 - Flags: review?(aleth)
Attachment #8826611 - Flags: review+
https://hg.mozilla.org/comm-central/rev/76b9005c6896813cd79220cb745a4ec1bcdaa4d3
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Instantbird 53
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: