Closed Bug 1331009 Opened 4 years ago Closed 4 years ago

Allow line separator between await and its expression

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla54
Tracking Flags:
Tracking Status
firefox-esr45 --- unaffected
firefox51 --- unaffected
firefox52 --- fixed
firefox-esr52 --- unaffected
firefox53 --- fixed
firefox54 --- fixed

People

(Reporter: anba, Assigned: arai)

References

Details

Attachments

(3 files)

Remove wrong restriction for a newline after await.
5.79 KB, patch
till
: review+
Details | Diff | Splinter Review
(mozilla-aurora) Remove wrong restriction for a newline after await. r=till
5.79 KB, patch
arai
: review+
jcristau
: approval-mozilla-aurora+
Details | Diff | Splinter Review
(mozilla-beta) Remove wrong restriction for a newline after await. r=till
5.75 KB, patch
arai
: review+
jcristau
: approval-mozilla-beta+
Details | Diff | Splinter Review 
Test case:
---
async function f() {
    await
        0;
}
---

Expected: Parses successfully
Actual: Throws SyntaxError
Assignee: nobody → arai.unmht
Status: NEW → ASSIGNED
Blocks: 1185106
Removed wrong same-line check after TOK_AWAIT.
Attachment #8834915 - Flags: review?(till)
Comment on attachment 8834915 [details] [diff] [review]
Remove wrong restriction for a newline after await.

Review of attachment 8834915 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, thanks
Attachment #8834915 - Flags: review?(till) → review+
https://hg.mozilla.org/mozilla-central/rev/a16d5d08b268
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox54: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Approval Request Comment
> [Feature/Bug causing the regression]
Added by bug 1185106.

> [User impact if declined]
Throws error for valid JS syntax.

> [Is this code covered by automated tests?]
yes

> [Has the fix been verified in Nightly?]
yes

> [Needs manual test from QE? If yes, steps to reproduce]
no

> [List of other uplifts needed for the feature/fix]
none

> [Is the change risky?]
no

> [Why is the change risky/not risky?]
just removes unnecessary restriction that has no other effect.

> [String changes made/needed]
none
Attachment #8835671 - Flags: review+
Attachment #8835671 - Flags: approval-mozilla-aurora?
Approval Request Comment
> [Feature/Bug causing the regression]
Added by bug 1185106.

> [User impact if declined]
Throws error for valid JS syntax.

> [Is this code covered by automated tests?]
yes

> [Has the fix been verified in Nightly?]
yes

> [Needs manual test from QE? If yes, steps to reproduce]
no

> [List of other uplifts needed for the feature/fix]
none

> [Is the change risky?]
no

> [Why is the change risky/not risky?]
just removes unnecessary restriction that has no other effect.

> [String changes made/needed]
none
Attachment #8835672 - Flags: review+
Attachment #8835672 - Flags: approval-mozilla-beta?
Comment on attachment 8835671 [details] [diff] [review]
(mozilla-aurora) Remove wrong restriction for a newline after await. r=till

don't reject valid js syntax, aurora53+
Attachment #8835671 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment on attachment 8835672 [details] [diff] [review]
(mozilla-beta) Remove wrong restriction for a newline after await. r=till

don't reject valid js syntax, beta52+
Attachment #8835672 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.