1331065 - Please run the 'ES' job with a version of node that supports array.includes() (upgrade lint docker image to node 6)

Status: RESOLVED FIXED

(Taskcluster Graveyard :: Docker Images, defect)

Description

[Florian Quèze [:florian]]

The custom rule I added in bug 1330464 broke the ES job on treeherder with an error caused by not supporting array.includes().

It's unfortunate that the behavior on the test infrastructure doesn't match what I had by default locally.

Comment 1

[Mark Banner (:standard8)]

We need to do this with the taskcluster image, and I think I know how to do it.

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1331065 - Upgrade the Lint docker image to node v6.9.1.

Review commit: https://reviewboard.mozilla.org/r/106052/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/106052/

Comment 3

[Mark Banner (:standard8)]

If I understand things correctly, Taskcluster will automatically rebuild the docker images when a push is made. So these changes should be picked up on push.

I've also pushed them to try server to verify it doesn't break anything:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e1e265e15f95

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8828764 [details]
Bug 1331065 - Upgrade the Lint docker image to node v6.9.1.

https://reviewboard.mozilla.org/r/106052/#review107018

thanks for doing this.  As your try push showed, there were images created and used for testing- we have had some hiccups with image creation and timing of them being available, but pushing to try first usually solves the problem.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/10e2e2b01b66
Upgrade the Lint docker image to node v6.9.1. r=jmaher

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/10e2e2b01b66

Comment 7

[Dave Townsend [:mossop]]

Please remember to update the mach command with the new minimum required version of node when making a change like this so developers get warned when they are out of date (bug 1346014).