Closed Bug 1331065 Opened 4 years ago Closed 4 years ago
Please run the 'ES' job with a version of node that supports array
.includes() (upgrade lint docker image to node 6)
59 bytes, text/x-review-board-request
The custom rule I added in bug 1330464 broke the ES job on treeherder with an error caused by not supporting array.includes(). It's unfortunate that the behavior on the test infrastructure doesn't match what I had by default locally.
We need to do this with the taskcluster image, and I think I know how to do it.
Component: Lint → Docker Images
Product: Testing → Taskcluster
Version: Version 3 → unspecified
Summary: Please run the 'ES' job with a version of node that supports array.includes() → Please run the 'ES' job with a version of node that supports array.includes() (upgrade lint docker image to node 6)
If I understand things correctly, Taskcluster will automatically rebuild the docker images when a push is made. So these changes should be picked up on push. I've also pushed them to try server to verify it doesn't break anything: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e1e265e15f95
Comment on attachment 8828764 [details] Bug 1331065 - Upgrade the Lint docker image to node v6.9.1. https://reviewboard.mozilla.org/r/106052/#review107018 thanks for doing this. As your try push showed, there were images created and used for testing- we have had some hiccups with image creation and timing of them being available, but pushing to try first usually solves the problem.
Attachment #8828764 - Flags: review?(jmaher) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/10e2e2b01b66 Upgrade the Lint docker image to node v6.9.1. r=jmaher
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Please remember to update the mach command with the new minimum required version of node when making a change like this so developers get warned when they are out of date (bug 1346014).
You need to log in before you can comment on or make changes to this bug.