Closed Bug 1331066 Opened 3 years ago Closed 3 years ago

Clean up #ifdef MOZ_ENABLE_WEBRENDER in GLContextProviderWGL.cpp

Categories

(Core :: Graphics: WebRender, defect, P3)

53 Branch
x86_64
Windows
defect

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox53 --- affected

People

(Reporter: kats, Assigned: kats)

References

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file)

https://hg.mozilla.org/projects/graphics/rev/c647de564cb7307fe46d17a2dd2ff4b0463d2fa9#l8.47 - I added an #ifdef MOZ_ENABLE_WEBRENDER for the depth bits, but that isn't quite correct. Really we want to use the "24" value for windows that will be composited with webrender. There may be non-webrender windows in MOZ_ENABLE_WEBRENDER builds.
Now that we're back to a "all compositors use webrender, or none do" (bug 1337085) we can use gfxVars to make this selection, so that's what the patch above does.
Depends on: 1337085
Comment on attachment 8835089 [details]
Bug 1331066 - Use gfxVars instead of a compile-time flag for webrender-conditional code.

https://reviewboard.mozilla.org/r/110800/#review112204
Attachment #8835089 - Flags: review?(sotaro.ikeda.g) → review+
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/193461498ba3
Use gfxVars instead of a compile-time flag for webrender-conditional code. r=sotaro
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.