Closed Bug 1331081 Opened 4 years ago Closed 4 years ago

omit addEventListener/removeEventListener's third parameter when it's false

Categories

(Firefox :: General, defect)

53 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 53
Tracking Status
firefox53 --- fixed

People

(Reporter: florian, Assigned: florian)

References

Details

Attachments

(4 files)

Attached file addEventListener.js
This third "useCapture" parameter has been optional since Firefox 6 according to MDN. Maybe it's time to cleanup our tree?
Attachment #8826731 - Attachment mime type: application/binary → text/plain
Assignee: nobody → florian
Status: NEW → ASSIGNED
https://hg.mozilla.org/integration/mozilla-inbound/rev/75273bfebf132de44ade1edf06a231c7add0effa
Bug 1331081 - make the no-useless-parameters eslint rule report useless addEventListener false third parameter, r=jaws.

https://hg.mozilla.org/integration/mozilla-inbound/rev/7b434711753b98a87603453caaa0945791ffe12b
Bug 1331081 - script generated patch to omit addEventListener/removeEventListener's third parameter when it's false, r=jaws.
Thanks for the reviews!

(In reply to Florian Quèze [:florian] [:flo] from comment #4)

> https://hg.mozilla.org/integration/mozilla-inbound/rev/
> 7b434711753b98a87603453caaa0945791ffe12b
> Bug 1331081 - script generated patch to omit
> addEventListener/removeEventListener's third parameter when it's false,
> r=jaws.

The changeset I landed is the result of re-running the same script to remove bitrot (already 10 hunks in 9 files that were not applying anymore), and exclude the dom/canvas/test/webgl-conf/checkout folder, where it seems we aren't the initial authors.
https://hg.mozilla.org/mozilla-central/rev/75273bfebf13
https://hg.mozilla.org/mozilla-central/rev/7b434711753b
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
Depends on: 1332910
Comment on attachment 8828001 [details] [diff] [review]
script generated patch for comm-central

Sorry, totally missed this one. If the patch still applies and/or you are willing to run the script again, I'm fine with a rs+ for landing.
Attachment #8828001 - Flags: review?(philipp) → review+
Pushed by florian@queze.net:
https://hg.mozilla.org/comm-central/rev/21f2508f16a2
omit addEventListener/removeEventListener's third parameter when it's false, rs=Fallen.
You need to log in before you can comment on or make changes to this bug.