omit addEventListener/removeEventListener's third parameter when it's false

RESOLVED FIXED in Firefox 53

Status

()

Firefox
General
RESOLVED FIXED
4 months ago
3 months ago

People

(Reporter: florian, Assigned: florian)

Tracking

53 Branch
Firefox 53
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox53 fixed)

Details

Attachments

(4 attachments)

(Assignee)

Description

4 months ago
Created attachment 8826731 [details]
addEventListener.js

This third "useCapture" parameter has been optional since Firefox 6 according to MDN. Maybe it's time to cleanup our tree?
(Assignee)

Updated

4 months ago
Attachment #8826731 - Attachment mime type: application/binary → text/plain
(Assignee)

Comment 1

4 months ago
Created attachment 8826732 [details] [diff] [review]
eslint rule change
Attachment #8826732 - Flags: review?(jaws)
(Assignee)

Updated

4 months ago
Assignee: nobody → florian
Status: NEW → ASSIGNED
(Assignee)

Comment 2

4 months ago
Created attachment 8826737 [details] [diff] [review]
script generated patch
Attachment #8826737 - Flags: review?(jaws)
(Assignee)

Comment 3

4 months ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=31c43904fba5
Attachment #8826732 - Flags: review?(jaws) → review+
Attachment #8826737 - Flags: review?(jaws) → review+
(Assignee)

Comment 4

3 months ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/75273bfebf132de44ade1edf06a231c7add0effa
Bug 1331081 - make the no-useless-parameters eslint rule report useless addEventListener false third parameter, r=jaws.

https://hg.mozilla.org/integration/mozilla-inbound/rev/7b434711753b98a87603453caaa0945791ffe12b
Bug 1331081 - script generated patch to omit addEventListener/removeEventListener's third parameter when it's false, r=jaws.
(Assignee)

Comment 5

3 months ago
Thanks for the reviews!

(In reply to Florian Quèze [:florian] [:flo] from comment #4)

> https://hg.mozilla.org/integration/mozilla-inbound/rev/
> 7b434711753b98a87603453caaa0945791ffe12b
> Bug 1331081 - script generated patch to omit
> addEventListener/removeEventListener's third parameter when it's false,
> r=jaws.

The changeset I landed is the result of re-running the same script to remove bitrot (already 10 hunks in 9 files that were not applying anymore), and exclude the dom/canvas/test/webgl-conf/checkout folder, where it seems we aren't the initial authors.
(Assignee)

Updated

3 months ago
Blocks: 1331599

Comment 6

3 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/75273bfebf13
https://hg.mozilla.org/mozilla-central/rev/7b434711753b
Status: ASSIGNED → RESOLVED
Last Resolved: 3 months ago
status-firefox53: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
(Assignee)

Comment 7

3 months ago
Created attachment 8828001 [details] [diff] [review]
script generated patch for comm-central
Attachment #8828001 - Flags: review?(philipp)
Depends on: 1332910
You need to log in before you can comment on or make changes to this bug.