Closed Bug 1331081 Opened 7 years ago Closed 7 years ago

omit addEventListener/removeEventListener's third parameter when it's false

Categories

(Firefox :: General, defect)

Product:
Firefox
Component:
General
Version:
53 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 53
Tracking Flags:
Tracking Status
firefox53 --- fixed

People

(Reporter: florian, Assigned: florian)

References

Details

Attachments

(4 files)

addEventListener.js
7.37 KB, text/plain
Details
eslint rule change
4.35 KB, patch
jaws
: review+
Details | Diff | Splinter Review
script generated patch
2.19 MB, patch
jaws
: review+
Details | Diff | Splinter Review
script generated patch for comm-central
528.12 KB, patch
Fallen
: review+
Details | Diff | Splinter Review
Attached file addEventListener.js — 
This third "useCapture" parameter has been optional since Firefox 6 according to MDN. Maybe it's time to cleanup our tree?
Attachment #8826731 - Attachment mime type: application/binary → text/plain

        Attachment #8826732 -
        Flags: review?(jaws)

    
  
Assignee: nobody → florian
Status: NEW → ASSIGNED

    
    

    
  


  

        Attachment #8826737 -
        Flags: review?(jaws)

        Attachment #8826732 -
        Flags: review?(jaws) → review+

        Attachment #8826737 -
        Flags: review?(jaws) → review+

    
    

    
  
https://hg.mozilla.org/integration/mozilla-inbound/rev/75273bfebf132de44ade1edf06a231c7add0effa
Bug 1331081 - make the no-useless-parameters eslint rule report useless addEventListener false third parameter, r=jaws.

https://hg.mozilla.org/integration/mozilla-inbound/rev/7b434711753b98a87603453caaa0945791ffe12b
Bug 1331081 - script generated patch to omit addEventListener/removeEventListener's third parameter when it's false, r=jaws.

    
    

    
  
Thanks for the reviews!

(In reply to Florian Quèze [:florian] [:flo] from comment #4)

> https://hg.mozilla.org/integration/mozilla-inbound/rev/
> 7b434711753b98a87603453caaa0945791ffe12b
> Bug 1331081 - script generated patch to omit
> addEventListener/removeEventListener's third parameter when it's false,
> r=jaws.

The changeset I landed is the result of re-running the same script to remove bitrot (already 10 hunks in 9 files that were not applying anymore), and exclude the dom/canvas/test/webgl-conf/checkout folder, where it seems we aren't the initial authors.

    
  
Blocks: 1331599

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/75273bfebf13
https://hg.mozilla.org/mozilla-central/rev/7b434711753b
Status: ASSIGNED → RESOLVED
Closed: 7 years ago

          status-firefox53:
          affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53

    
    

    
  


  

        Attachment #8828001 -
        Flags: review?(philipp)
Depends on: 1332910

    
    

    
  
Comment on attachment 8828001 [details] [diff] [review]
script generated patch for comm-central

Sorry, totally missed this one. If the patch still applies and/or you are willing to run the script again, I'm fine with a rs+ for landing.

        Attachment #8828001 -
        Flags: review?(philipp) → review+

    
    

    
  
Pushed by florian@queze.net:
https://hg.mozilla.org/comm-central/rev/21f2508f16a2
omit addEventListener/removeEventListener's third parameter when it's false, rs=Fallen.

          You need to log in
          before you can comment on or make changes to this bug.