1331081 - omit addEventListener/removeEventListener's third parameter when it's false

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Florian Quèze [:florian]]

Attachment: addEventListener.js

This third "useCapture" parameter has been optional since Firefox 6 according to MDN. Maybe it's time to cleanup our tree?

Comment 1

[Florian Quèze [:florian]]

Attachment: eslint rule change

Comment 2

[Florian Quèze [:florian]]

Attachment: script generated patch

Comment 3

[Florian Quèze [:florian]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=31c43904fba5

Comment 4

[Florian Quèze [:florian]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/75273bfebf132de44ade1edf06a231c7add0effa
Bug 1331081 - make the no-useless-parameters eslint rule report useless addEventListener false third parameter, r=jaws.

https://hg.mozilla.org/integration/mozilla-inbound/rev/7b434711753b98a87603453caaa0945791ffe12b
Bug 1331081 - script generated patch to omit addEventListener/removeEventListener's third parameter when it's false, r=jaws.

Comment 5

[Florian Quèze [:florian]]

Thanks for the reviews!

(In reply to Florian Quèze [:florian] [:flo] from comment #4)

> https://hg.mozilla.org/integration/mozilla-inbound/rev/
> 7b434711753b98a87603453caaa0945791ffe12b
> Bug 1331081 - script generated patch to omit
> addEventListener/removeEventListener's third parameter when it's false,
> r=jaws.

The changeset I landed is the result of re-running the same script to remove bitrot (already 10 hunks in 9 files that were not applying anymore), and exclude the dom/canvas/test/webgl-conf/checkout folder, where it seems we aren't the initial authors.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/75273bfebf13
https://hg.mozilla.org/mozilla-central/rev/7b434711753b

Comment 7

[Florian Quèze [:florian]]

Attachment: script generated patch for comm-central

Comment 8

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 8828001 [details] [diff] [review]
script generated patch for comm-central

Sorry, totally missed this one. If the patch still applies and/or you are willing to run the script again, I'm fine with a rs+ for landing.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/21f2508f16a2
omit addEventListener/removeEventListener's third parameter when it's false, rs=Fallen.