1331164 - The checkbox with the record call stack label is not vertical aligned in Memory tab

Status: VERIFIED FIXED

(DevTools :: Memory, defect)

Description

[[:Towkir] Ahmed]

Attachment: checkbox_alignment_issue_MEMORY_tab.gif

Comment 1

[[:Towkir] Ahmed]

Attachment: checkbox_alignment_issue_MEMORY_tab_fixed_with_patch_applied.gif

Adding these properties:

display: flex;
align-items: center;

to this rule: https://dxr.mozilla.org/mozilla-central/source/devtools/client/themes/memory.css#98

seems to fix the issue.

Here is an attachment showing the result after the patch applied.

Comment 2

[[:Towkir] Ahmed]

Hi Nick,
what do you think ? if my suggestion looks good and you think it is safe to do so, I can submit a patch.

Comment 3

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

From the gifs, it looks good to me. Care to attach a patch and flag :ntim for review? Thanks!

Comment 4

[[:Towkir] Ahmed]

Thanks Nick, I will submit a patch soon.
Assigning for now.

Comment 5

[[:Towkir] Ahmed]

Attachment: devtool-label-checkbox.patch

Hi Tim, please have a look at this. Hope this works

Comment 6

[Tim Nguyen :ntim]

Comment on attachment 8827921 [details] [diff] [review]
devtool-label-checkbox.patch

Review of attachment 8827921 [details] [diff] [review]:
-----------------------------------------------------------------

Works great, thanks!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6c4f431d9085
The checkbox with the record call stack label is now vertically aligned in Memory tab. r=ntim

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6c4f431d9085

Comment 9

[Azmina]

I have reproduced this bug with Nightly 53.0a1 (2017-01-13) on Windows 8.1(64-bit).

This bug's fix is verified on Aurora 53.0a2.

Build ID : 20170126004004
User Agent : Mozilla/5.0 (Windows NT 6.3; WOW64; rv:53.0) Gecko/20100101 Firefox/53.0

[bugday-20170125]