The checkbox with the record call stack label is not vertical aligned in Memory tab

VERIFIED FIXED in Firefox 53

Status

()

Firefox
Developer Tools: Memory
VERIFIED FIXED
10 months ago
10 months ago

People

(Reporter: Towkir, Assigned: Towkir)

Tracking

Trunk
Firefox 53
Points:
---

Firefox Tracking Flags

(firefox53 verified)

Details

Attachments

(3 attachments)

(Assignee)

Description

10 months ago
Created attachment 8826825 [details]
checkbox_alignment_issue_MEMORY_tab.gif
(Assignee)

Comment 1

10 months ago
Created attachment 8826826 [details]
checkbox_alignment_issue_MEMORY_tab_fixed_with_patch_applied.gif

Adding these properties:

display: flex;
align-items: center;

to this rule: https://dxr.mozilla.org/mozilla-central/source/devtools/client/themes/memory.css#98

seems to fix the issue.

Here is an attachment showing the result after the patch applied.
(Assignee)

Comment 2

10 months ago
Hi Nick,
what do you think ? if my suggestion looks good and you think it is safe to do so, I can submit a patch.
Flags: needinfo?(nfitzgerald)
From the gifs, it looks good to me. Care to attach a patch and flag :ntim for review? Thanks!
Flags: needinfo?(nfitzgerald) → needinfo?(3ugzilla)
(Assignee)

Comment 4

10 months ago
Thanks Nick, I will submit a patch soon.
Assigning for now.
Assignee: nobody → 3ugzilla
Status: NEW → ASSIGNED
Flags: needinfo?(3ugzilla)
(Assignee)

Comment 5

10 months ago
Created attachment 8827921 [details] [diff] [review]
devtool-label-checkbox.patch

Hi Tim, please have a look at this. Hope this works
Attachment #8827921 - Flags: review?(ntim.bugs)

Comment 6

10 months ago
Comment on attachment 8827921 [details] [diff] [review]
devtool-label-checkbox.patch

Review of attachment 8827921 [details] [diff] [review]:
-----------------------------------------------------------------

Works great, thanks!
Attachment #8827921 - Flags: review?(ntim.bugs) → review+

Updated

10 months ago
Keywords: checkin-needed

Comment 7

10 months ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6c4f431d9085
The checkbox with the record call stack label is now vertically aligned in Memory tab. r=ntim
Keywords: checkin-needed

Comment 8

10 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/6c4f431d9085
Status: ASSIGNED → RESOLVED
Last Resolved: 10 months ago
status-firefox53: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53

Comment 9

10 months ago
I have reproduced this bug with Nightly 53.0a1 (2017-01-13) on Windows 8.1(64-bit).

This bug's fix is verified on Aurora 53.0a2.

Build ID : 20170126004004
User Agent : Mozilla/5.0 (Windows NT 6.3; WOW64; rv:53.0) Gecko/20100101 Firefox/53.0

[bugday-20170125]

Updated

10 months ago
Status: RESOLVED → VERIFIED
status-firefox53: fixed → verified
You need to log in before you can comment on or make changes to this bug.