Closed
Bug 1331167
Opened 7 years ago
Closed 7 years ago
image tooltip (requests-menu-icon) does not auto hide on hovering out of devtool
Categories
(DevTools :: Shared Components, defect, P3)
DevTools
Shared Components
Tracking
(firefox53 affected, firefox58 fixed)
RESOLVED
FIXED
Firefox 58
People
(Reporter: Towkir, Assigned: jdescottes)
Details
Attachments
(2 files, 1 obsolete file)
Make sure the row you are hovering on is the firs one on the scrolled view (not necessary to be the first in the list, just firs on the viewport) so that when you hover the mouse up (out or in the devtool) no other rows are hovered on. Then see the tooltip remaining visible.
Comment 2•7 years ago
|
||
Yep, I can reproduce the issue on my machine. Thanks for the report! I think it's a bug in HTMLTooltip ("devtools/client/shared/widgets/tooltip/HTMLTooltip"). Here is another STR (related to the Inspector panel): 1) Open DevTools and select the Inspector panel 2) Hover mouse over an image in the Inspector panel (you need to have <img> tag on the page) 3) Make sure the tag is scrolled as the first or last one in the (markupview) viewport so, you can move your mouse out of the (markup) view. 4) As you leave the image the tooltip is still there -> BUG @Julian: This seems to belong to "Framework" component, can you confirm? Honza
Flags: needinfo?(odvarko) → needinfo?(jdescottes)
Assignee | ||
Comment 3•7 years ago
|
||
Thanks for filing! I think the issue lies with the TooltipToggle, not directly the HTMLTooltip (-> devtools/client/shared/widgets/tooltip/TooltipToggle.js). I actually have a work in progress patch for this issue. I will push it here in case anyone wants to finish it (mostly adding tests I guess).
Component: Developer Tools: Netmonitor → Developer Tools: Shared Components
Flags: needinfo?(jdescottes)
Priority: -- → P3
Assignee | ||
Comment 4•7 years ago
|
||
Assignee | ||
Comment 5•7 years ago
|
||
The patch attached above should fix both STRs. There was a weird flaw in the logic of the TooltipToggle. However this needs a lot of testing to check the behavior of all tooltips using the toggle is still correct. That means the tooltips in the markup view, in the rule/computed view and in the network monitor.
Comment 6•7 years ago
|
||
I can confirm that the patch fixes the problem on my machine (both the Inspector and Network panel). Thanks Julian, Honza
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Assignee | ||
Comment 8•7 years ago
|
||
Thanks for the feedback Honza, I realize I never actually submitted my patch to review. Let's try to land this simple fix. Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=fd90dac4f04341203226f220c46149c35a1631aa
Comment 9•7 years ago
|
||
mozreview-review |
Comment on attachment 8837146 [details] Bug 1331167 - fix TooltipToggle to hide tooltip when leaving target; https://reviewboard.mozilla.org/r/112384/#review114886 Tested again and the patch fixes the problem for me. Do note that there is a conflict when applying the patch in browser_net_image-tooltip.js test file R+ assuming try is green. Thanks! Honza
Attachment #8837146 -
Flags: review?(odvarko) → review+
Comment hidden (mozreview-request) |
Assignee | ||
Comment 11•7 years ago
|
||
Thanks for the review Honza, sorry I left this one on the side. I rebased and fixed the conflict with browser_net_image-tooltip.js. Can't reproduce any of the try failures locally on OSX or Linux. Started a new try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d71f347223e220570e2cc8eb01bf0c10a7895e04
Comment hidden (mozreview-request) |
Assignee | ||
Comment 14•7 years ago
|
||
Sorry, forgot to land. Thanks for the heads up Towkir!
Flags: needinfo?(jdescottes)
Comment 15•7 years ago
|
||
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7c952d1beaaf fix TooltipToggle to hide tooltip when leaving target;r=Honza
Comment 16•7 years ago
|
||
Backed out for failures in devtools' tooltip tests, e.g. devtools/client/inspector/shared/test/browser_styleinspector_tooltip-background-image.js: https://hg.mozilla.org/integration/autoland/rev/f8b6f4681fb8830cbdb904c0ee77313ebfebc31e Push which ran failing tests: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=cd1c3f84f3ec96ace1c361d249b80214fe52f672&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=133293082&repo=autoland [task 2017-09-26T09:33:16.514Z] 09:33:16 INFO - Waiting for tooltip to be shown [task 2017-09-26T09:33:16.517Z] 09:33:16 INFO - TEST-PASS | devtools/client/inspector/shared/test/browser_styleinspector_tooltip-background-image.js | The tooltip 'previewTooltip' is visible - [task 2017-09-26T09:33:16.519Z] 09:33:16 INFO - TEST-PASS | devtools/client/inspector/shared/test/browser_styleinspector_tooltip-background-image.js | Tooltip contains an image - [task 2017-09-26T09:33:16.520Z] 09:33:16 INFO - TEST-PASS | devtools/client/inspector/shared/test/browser_styleinspector_tooltip-background-image.js | The image URL seems fine - [task 2017-09-26T09:33:16.523Z] 09:33:16 INFO - Buffered messages finished [task 2017-09-26T09:33:16.526Z] 09:33:16 INFO - TEST-UNEXPECTED-FAIL | devtools/client/inspector/shared/test/browser_styleinspector_tooltip-background-image.js | Test timed out - [task 2017-09-26T09:33:16.528Z] 09:33:16 INFO - TEST-PASS | devtools/client/inspector/shared/test/browser_styleinspector_tooltip-background-image.js | The tooltip is hidden on mouseout - [task 2017-09-26T09:33:16.530Z] 09:33:16 INFO - Selecting the test div node [task 2017-09-26T09:33:16.533Z] 09:33:16 INFO - Selecting the node for '.test-element' [task 2017-09-26T09:33:16.534Z] 09:33:16 INFO - GECKO(1715) | ************************* [task 2017-09-26T09:33:16.536Z] 09:33:16 INFO - GECKO(1715) | A coding exception was thrown and uncaught in a Task. [task 2017-09-26T09:33:16.539Z] 09:33:16 INFO - GECKO(1715) | Full message: TypeError: this._toolbox is null [task 2017-09-26T09:33:16.541Z] 09:33:16 INFO - GECKO(1715) | Full stack: get walker@chrome://devtools/content/inspector/inspector.js:162:5 [task 2017-09-26T09:33:16.544Z] 09:33:16 INFO - GECKO(1715) | getNodeFront@chrome://mochitests/content/browser/devtools/client/inspector/test/shared-head.js:177:1 [task 2017-09-26T09:33:16.547Z] 09:33:16 INFO - GECKO(1715) | selectNode<@chrome://mochitests/content/browser/devtools/client/inspector/test/shared-head.js:196:25 [task 2017-09-26T09:33:16.550Z] 09:33:16 INFO - GECKO(1715) | _run@resource://devtools/shared/base-loader.js -> resource://devtools/shared/task.js:310:39 [task 2017-09-26T09:33:16.552Z] 09:33:16 INFO - GECKO(1715) | TaskImpl@resource://devtools/shared/base-loader.js -> resource://devtools/shared/task.js:272:3 [task 2017-09-26T09:33:16.555Z] 09:33:16 INFO - GECKO(1715) | asyncFunction@resource://devtools/shared/base-loader.js -> resource://devtools/shared/task.js:246:14 [task 2017-09-26T09:33:16.557Z] 09:33:16 INFO - GECKO(1715) | @chrome://mochitests/content/browser/devtools/client/inspector/shared/test/browser_styleinspector_tooltip-background-image.js:36:9 [task 2017-09-26T09:33:16.559Z] 09:33:16 INFO - GECKO(1715) | TaskImpl_run@resource://gre/modules/Task.jsm:331:42 [task 2017-09-26T09:33:16.561Z] 09:33:16 INFO - GECKO(1715) | promise callback*TaskImpl_handleResultValue@resource://gre/modules/Task.jsm:408:7 [task 2017-09-26T09:33:16.563Z] 09:33:16 INFO - GECKO(1715) | Promise*scheduleWalkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:739:11 [task 2017-09-26T09:33:16.565Z] 09:33:16 INFO - GECKO(1715) | schedulePromise@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:770:7 [task 2017-09-26T09:33:16.567Z] 09:33:16 INFO - GECKO(1715) | completePromise@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:707:7 [task 2017-09-26T09:33:16.569Z] 09:33:16 INFO - GECKO(1715) | onResponse@resource://devtools/shared/base-loader.js -> resource://devtools/shared/DevToolsUtils.js:513:7 [task 2017-09-26T09:33:16.571Z] 09:33:16 INFO - GECKO(1715) | onStopRequest@resource://gre/modules/NetUtil.jsm:131:17 [task 2017-09-26T09:33:16.573Z] 09:33:16 INFO - GECKO(1715) | ************************* [task 2017-09-26T09:33:16.574Z] 09:33:16 INFO - GECKO(1715) | ************************* [task 2017-09-26T09:33:16.575Z] 09:33:16 INFO - GECKO(1715) | A coding exception was thrown and uncaught in a Task. [task 2017-09-26T09:33:16.576Z] 09:33:16 INFO - GECKO(1715) | Full message: TypeError: this._toolbox is null [task 2017-09-26T09:33:16.577Z] 09:33:16 INFO - GECKO(1715) | Full stack: get walker@chrome://devtools/content/inspector/inspector.js:162:5 [task 2017-09-26T09:33:16.578Z] 09:33:16 INFO - GECKO(1715) | getNodeFront@chrome://mochitests/content/browser/devtools/client/inspector/test/shared-head.js:177:1 [task 2017-09-26T09:33:16.580Z] 09:33:16 INFO - GECKO(1715) | selectNode<@chrome://mochitests/content/browser/devtools/client/inspector/test/shared-head.js:196:25 [task 2017-09-26T09:33:16.581Z] 09:33:16 INFO - GECKO(1715) | _run@resource://devtools/shared/base-loader.js -> resource://devtools/shared/task.js:310:39 [task 2017-09-26T09:33:16.582Z] 09:33:16 INFO - GECKO(1715) | TaskImpl@resource://devtools/shared/base-loader.js -> resource://devtools/shared/task.js:272:3 [task 2017-09-26T09:33:16.583Z] 09:33:16 INFO - GECKO(1715) | asyncFunction@resource://devtools/shared/base-loader.js -> resource://devtools/shared/task.js:246:14 [task 2017-09-26T09:33:16.584Z] 09:33:16 INFO - GECKO(1715) | @chrome://mochitests/content/browser/devtools/client/inspector/shared/test/browser_styleinspector_tooltip-background-image.js:36:9 [task 2017-09-26T09:33:16.585Z] 09:33:16 INFO - GECKO(1715) | Tester_execTest@chrome://mochikit/content/browser-test.js:798:9 [task 2017-09-26T09:33:16.586Z] 09:33:16 INFO - GECKO(1715) | Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:697:9 [task 2017-09-26T09:33:16.587Z] 09:33:16 INFO - GECKO(1715) | SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:795:59 [task 2017-09-26T09:33:16.589Z] 09:33:16 INFO - GECKO(1715) | ************************* [task 2017-09-26T09:33:16.590Z] 09:33:16 INFO - Not taking screenshot here: see the one that was previously logged [task 2017-09-26T09:33:16.591Z] 09:33:16 INFO - TEST-UNEXPECTED-FAIL | devtools/client/inspector/shared/test/browser_styleinspector_tooltip-background-image.js | Uncaught exception received from previously timed out test - at chrome://devtools/content/inspector/inspector.js:162 - TypeError: this._toolbox is null [task 2017-09-26T09:33:16.592Z] 09:33:16 INFO - Stack trace: [task 2017-09-26T09:33:16.593Z] 09:33:16 INFO - get walker@chrome://devtools/content/inspector/inspector.js:162:5 [task 2017-09-26T09:33:16.594Z] 09:33:16 INFO - getNodeFront@chrome://mochitests/content/browser/devtools/client/inspector/test/shared-head.js:177:1 [task 2017-09-26T09:33:16.595Z] 09:33:16 INFO - selectNode<@chrome://mochitests/content/browser/devtools/client/inspector/test/shared-head.js:196:25 [task 2017-09-26T09:33:16.596Z] 09:33:16 INFO - _run@resource://devtools/shared/base-loader.js -> resource://devtools/shared/task.js:310:39 [task 2017-09-26T09:33:16.597Z] 09:33:16 INFO - TaskImpl@resource://devtools/shared/base-loader.js -> resource://devtools/shared/task.js:272:3 [task 2017-09-26T09:33:16.598Z] 09:33:16 INFO - asyncFunction@resource://devtools/shared/base-loader.js -> resource://devtools/shared/task.js:246:14 [task 2017-09-26T09:33:16.599Z] 09:33:16 INFO - @chrome://mochitests/content/browser/devtools/client/inspector/shared/test/browser_styleinspector_tooltip-background-image.js:36:9 [task 2017-09-26T09:33:16.600Z] 09:33:16 INFO - Tester_execTest@chrome://mochikit/content/browser-test.js:798:9 [task 2017-09-26T09:33:16.601Z] 09:33:16 INFO - Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:697:9 [task 2017-09-26T09:33:16.602Z] 09:33:16 INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:795:59 [task 2017-09-26T09:33:16.603Z] 09:33:16 INFO - Tester_execTest@chrome://mochikit/content/browser-test.js:798:9 [task 2017-09-26T09:33:16.604Z] 09:33:16 INFO - Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:697:9 [task 2017-09-26T09:33:16.605Z] 09:33:16 INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:795:59 [task 2017-09-26T09:33:16.606Z] 09:33:16 INFO - Removing tab.
Flags: needinfo?(jdescottes)
Assignee | ||
Comment 17•7 years ago
|
||
Sorry about that. New try at: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3f149c0943018b0d04ba1c9a066adcc96cb1c01a
Flags: needinfo?(jdescottes)
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 20•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=870d79e1672f90460a42d91c2f37f1cd54717a6e
Assignee | ||
Updated•7 years ago
|
Attachment #8827183 -
Attachment is obsolete: true
Comment 21•7 years ago
|
||
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bacc64f220bd fix TooltipToggle to hide tooltip when leaving target;r=Honza
Comment 22•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/bacc64f220bd
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•