Remove Windows shell integration and xpcom checks for Windows Vista

RESOLVED FIXED in Firefox 54

Status

()

Core
XPCOM
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: cpeterson, Assigned: cpeterson)

Tracking

(Depends on: 1 bug)

51 Branch
mozilla54
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox50 wontfix, firefox51 wontfix, firefox52 wontfix, firefox53 affected, firefox54 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(3 attachments)

(Assignee)

Description

a year ago
Now that Firefox 53 no longer supports Windows XP or Vista, we can remove unnecessary Windows version checks for XP, Vista, and 7.

Here is a green Try run:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=51f08cea49f983d343706cccdb9bd92e1657bb75
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 4

a year ago
mozreview-review
Comment on attachment 8826899 [details]
Bug 1331171 - Part 1: Remove StartupSpecialSystemDirectory() workaround for Windows XP.

https://reviewboard.mozilla.org/r/104724/#review105456

::: xpcom/io/SpecialSystemDirectory.cpp:14
(Diff revision 1)
> +#ifdef _WIN32_WINNT
> +#undef _WIN32_WINNT
> +#endif
> +#define _WIN32_WINNT 0x0600

FWIW, bug 1325299 is busy making this the default everywhere.
(Assignee)

Updated

a year ago
Depends on: 1325299

Comment 5

a year ago
mozreview-review
Comment on attachment 8826901 [details]
Bug 1331171 - Part 3: Remove xpcom checks for Windows Vista.

https://reviewboard.mozilla.org/r/104728/#review105940

Thank you!
Attachment #8826901 - Flags: review?(nfroyd) → review+

Comment 6

a year ago
mozreview-review
Comment on attachment 8826899 [details]
Bug 1331171 - Part 1: Remove StartupSpecialSystemDirectory() workaround for Windows XP.

https://reviewboard.mozilla.org/r/104724/#review106312

r+ on the removal of the code, but lets wait until we can avoid the added platform ifdef work.

::: xpcom/io/SpecialSystemDirectory.cpp:14
(Diff revision 1)
> +#ifdef _WIN32_WINNT
> +#undef _WIN32_WINNT
> +#endif
> +#define _WIN32_WINNT 0x0600

I like the idea of blocking on this and updating this patch.
Attachment #8826899 - Flags: review?(jmathies) → review+

Comment 7

a year ago
mozreview-review
Comment on attachment 8826900 [details]
Bug 1331171 - Part 2: Remove Windows shell integration checks for Windows Vista.

https://reviewboard.mozilla.org/r/104726/#review106320
Attachment #8826900 - Flags: review?(jmathies) → review+
(Assignee)

Comment 8

a year ago
(In reply to Jim Mathies [:jimm] from comment #6)
> ::: xpcom/io/SpecialSystemDirectory.cpp:14
> (Diff revision 1)
> > +#ifdef _WIN32_WINNT
> > +#undef _WIN32_WINNT
> > +#endif
> > +#define _WIN32_WINNT 0x0600
> 
> I like the idea of blocking on this and updating this patch.

Sounds good. I'll wait for _WIN32_WINNT bug 1325299 to land and then rebase my patches.

Comment 9

a year ago
Pushed by cpeterson@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/db3691e4c328
Part 1: Remove StartupSpecialSystemDirectory() workaround for Windows XP. r=jimm
https://hg.mozilla.org/integration/mozilla-inbound/rev/00edf253517f
Part 2: Remove Windows shell integration checks for Windows Vista. r=jimm
https://hg.mozilla.org/integration/mozilla-inbound/rev/be835d18c74f
Part 3: Remove xpcom checks for Windows Vista. r=froydnj

Comment 10

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/db3691e4c328
https://hg.mozilla.org/mozilla-central/rev/00edf253517f
https://hg.mozilla.org/mozilla-central/rev/be835d18c74f
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.