1331190 - Log viewer sometimes doesn't load the log

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P1)

Description

[Kartikaya Gupta (email:[e-mail])]

Occasionally I look at the log for a job and the bottom pane (where the log shows up) doesn't seem to load or is just empty. I just saw it on https://treeherder.mozilla.org/logviewer.html#?job_id=69022188&repo=graphics&lineNumber=20881

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Error console screenshot

There's a JS error in the console, see attached.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

And it seems intermittent, I just did a shift-reload on the same page again and it loaded fine (no error in the JS console either)

Comment 3

[William Lachance (:wlach)]

Hassan, could you look at this when you have time?

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I saw this once last night, so it's not just something on kats' machine.

Comment 5

[GitHub Autolander Bot]

Attachment: [treeherder] helfi92:viewer-sometimes-doesnt-load > mozilla:master

Comment 6

[Ed Morley [:emorley]]

Thank you for looking into this :-)

Comment 7

[Hassan Ali (:hassan)]

Always a pleasure :)

Comment 8

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/bd56ccab3fb4d96af59394b307bac4502f205ce7
Bug 1331190 - Log viewer sometimes doesn't load the log (#2083)

Occasionally the log viewer doesn't seem to load. The JS error in the
console was `q.lineNumber.split is not a function`. This was happening
because `q.lineNumber` was sometimes interpreted as a number. To fix
that, the use of `toString()` is used before splitting it.

Comment 9

[William Lachance (:wlach)]

I think we can (hopefully) mark this as fixed. Should be on production soon.