1331242 - Typo: "HTTP/2.0" should be displayed as "HTTP/2" (Network Monitor, DevTools))

Status: RESOLVED WORKSFORME

(Core :: Networking: HTTP, defect, P3)

Description

[Yoshihiro Iwanaga]

Attachment: screenshot.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:50.0) Gecko/20100101 Firefox/50.0
Build ID: 20161208153507

Steps to reproduce:

1. Access a server supports HTTP/2.
2. Open Network Tab in Developer Tools.
3. Click one of requests.



Actual results:

"Version" value is "HTTP/2.0" in Headers tab, as the attached screenshot image.


Expected results:

The value should be "HTTP/2".

I guess this can be fixed just changing this line:
https://dxr.mozilla.org/mozilla-central/source/netwerk/protocol/http/nsHttpTransaction.cpp#1283

(Note)
https://http2.github.io/faq/#is-it-http20-or-http2

> Is it HTTP/2.0 or HTTP/2?
> 
> The Working Group decided to drop the minor version (“.0”) because it has caused a lot of confusion in HTTP/1.x.
> 
> In other words, the HTTP version only indicates wire compatibility, not feature sets or “marketing.”

Comment 1

[u408661]

Yeah, this is a known thing (though I never filed a bug for it, because it's a minor thing). Basically, we have code that depends on there being a ".x" in the version number, so the simplest way to display HTTP/2 was to make it HTTP/2.0. I suspect the easiest place to fix this would be in the devtools, where the display happens, so we don't have to special-case HTTP >= 2 in a number of other places. The right thing to do, though, would be to make everywhere else understand "no .x ~= .0", so we don't have to keep doing this dance for HTTP/3 and other potential future versions. So I guess this is the right component, though this isn't particularly urgent... (yes, I'm triaging out-of-turn, I doubt whoever's on triage this week will mind me jumping in)

Comment 2

[Firefox Bug Husbandry Bot]

Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258

Comment 3

[Firefox Bug Husbandry Bot]

Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258

Comment 4

[Bingru Zhao]

Hi I would like to fix this bug but as this is my first bug, can someone give me some guidance?

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Mass-removing myself from cc; search for 12b9dfe4-ece3-40dc-8d23-60e179f64ac1 or any reasonable part thereof, to mass-delete these notifications (and sorry!)

Comment 6

[hquest]

HTTP/3 is being identified as "HTTP/3". Which tells me there was a fix done somewhere, somehow, to not use the minor .0 as HTTP/2 used to. When can we expect HTTP/2 to be corrected, on par with RFC7540, and drop the minor .0 out of it?

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Clear a needinfo that is pending on an inactive user.

Inactive users most likely will not respond; if the missing information is essential and cannot be collected another way, the bug maybe should be closed as INCOMPLETE.

For more information, please visit auto_nag documentation.

Comment 8

[XU Kailiang]

It's now displayed as "HTTP/2" in Developer Tools.

(In reply to Yoshihiro Iwanaga from comment #0)

I guess this can be fixed just changing this line:
https://dxr.mozilla.org/mozilla-central/source/netwerk/protocol/http/nsHttpTransaction.cpp#1283

This line has been changed by https://hg.mozilla.org/mozilla-central/rev/9599e1491ce6 when fixing https://bugzilla.mozilla.org/show_bug.cgi?id=1623755.
So is this bug here (1331242) fixed?

Comment 9

[Sunil Mayya]

(In reply to XU Kailiang from comment #8)

It's now displayed as "HTTP/2" in Developer Tools.

(In reply to Yoshihiro Iwanaga from comment #0)

I guess this can be fixed just changing this line:
https://dxr.mozilla.org/mozilla-central/source/netwerk/protocol/http/nsHttpTransaction.cpp#1283

This line has been changed by https://hg.mozilla.org/mozilla-central/rev/9599e1491ce6 when fixing https://bugzilla.mozilla.org/show_bug.cgi?id=1623755.
So is this bug here (1331242) fixed?

This seems right. Thank you for pointing this out.