Closed Bug 1331264 Opened 5 years ago Closed 5 years ago

Wasm baseline: Avoid a temp + copy for unaligned store that is not tee_store

Categories

(Core :: JavaScript Engine: JIT, defect, P5)

ARM
All
defect

Tracking

()

RESOLVED WONTFIX

People

(Reporter: lth, Unassigned)

References

Details

A corner case that needs data from *real* applications before it's worth doing.

From store() in WasmBaselineCompile.cpp:

We perform the copy on the i32 path (and allocate the temp for the copy) because we will destroy the value in the temp.  We could avoid the copy and the temp if the caller would instead preserve src when it needs to return its value as a result (for teeStore). If unaligned accesses are common it will be worthwhile to make that change, but there's no evidence yet that they will be common.
Will be made obsolete by code removal in bug 1333370.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.