Remove "Disable Visual Themes" support?

NEW
Unassigned

Status

()

P3
normal
2 years ago
2 years ago

People

(Reporter: njn, Unassigned)

Tracking

Trunk
Unspecified
Windows
Points:
---

Firefox Tracking Flags

(firefox53 affected)

Details

(Whiteboard: tpi:+)

(Reporter)

Description

2 years ago
Bug 1325503 removed a lot of XP & Vista code in widget/, including some old file picker code. This regressed bug 751729, i.e. if you run with "Disable Visual Themes" (via the Compatibility tab of the Properties dialog of firefox.exe) the file picker will no longer open.

But there are additional issues when visual themes are disabled, including a problem with the titlebar command buttons not getting displayed. And jimm suspects that the use of this option is rare. So it might be time to drop support for that option.

BTW, this option appears to be a Win7 and Win8 thing. As far as I can tell it's not present in Win10.
What actions do we take? Just declare "we no longer care about any glitches when Disable Visual Themes is checked"?

Updated

2 years ago
Priority: -- → P1
Whiteboard: tpi:+

Comment 2

2 years ago
(In reply to Masatoshi Kimura [:emk] from comment #1)
> What actions do we take? Just declare "we no longer care about any glitches
> when Disable Visual Themes is checked"?

Yeah pretty much. I seriously doubt this affects many. I wonder if we could detect it and grab some telemetry?
Priority: P1 → P3
You need to log in before you can comment on or make changes to this bug.