Auto resize the height of textarea of "add comment"

RESOLVED FIXED

Status

()

bugzilla.mozilla.org
User Interface: Modal
RESOLVED FIXED
11 months ago
5 months ago

People

(Reporter: kuoe0, Assigned: wlach)

Tracking

(Blocks: 1 bug)

Production
Dependency tree / graph

Details

Attachments

(1 attachment, 1 obsolete attachment)

I think it would be a better experience when the height of the textarea of "add comment" would be resized automatically. I think it is a bad experience when we type a long comment and we have to scroll the little textarea to check it.

And the height of "preview" should be "auto", too. It makes the comment editor can preview his/her entire comment quickly.
Assignee: ui → nobody
Component: User Interface → User Interface: Modal
Product: Bugzilla → bugzilla.mozilla.org
QA Contact: default-qa
Version: 5.1.1 → Production
Assignee: nobody → kuoe0
Created attachment 8827765 [details] [review]
github pull request

I created a patch to make the comment textarea be resized automatically.
Attachment #8827765 - Flags: feedback?(dkl)
I'm going to +1 this, I frequently find the textarea to be too small when I'm editing anything but a very short comment. I think we might want to set some kind of upper limit on its size (I also commented to this effect on the PR)
Comment on attachment 8827765 [details] [review]
github pull request

Add a max height and I think this is a useful change.
Attachment #8827765 - Flags: feedback?(dkl) → feedback-
I updated the patch with setting 80% height of the viewport as the max height.
(Assignee)

Updated

10 months ago
Attachment #8827765 - Flags: review?(dylan)
Comment on attachment 8827765 [details] [review]
github pull request

For every character I add or remove the height of the comment box grows!
Here is a short video of what I saw:

https://www.youtube.com/watch?v=2Qs_Wd7ezSk
Attachment #8827765 - Flags: review?(dylan)
Attachment #8827765 - Flags: review-
Attachment #8827765 - Flags: feedback-
Created attachment 8884864 [details] [review]
PR using autosizer library

This finally annoyed me enough that I created an updated PR using the autosizer library. :)
Assignee: kuoe0 → wlachance
Attachment #8827765 - Attachment is obsolete: true
Attachment #8884864 - Flags: review?(dylan)
Comment on attachment 8884864 [details] [review]
PR using autosizer library

r-, per github comments:

Is there a way of making it readjust the size when the textarea changes? Currently if you reply to a long comment the box will not resize until you type stuff.

If that can't be fixed, let me know and I'll approve as is.
Attachment #8884864 - Flags: review?(dylan) → review-
Comment on attachment 8884864 [details] [review]
PR using autosizer library

PR updated
Attachment #8884864 - Flags: review- → review?(dylan)
Attachment #8884864 - Flags: review?(dylan) → review+
Status: NEW → RESOLVED
Last Resolved: 5 months ago
Resolution: --- → FIXED
Blocks: 1380336
Blocks: 1380352
Blocks: 1380389
Depends on: 1380414
You need to log in before you can comment on or make changes to this bug.