Clicking on a commit currently goes to '#index_header' on the diff page, which is the list of modified file. Unfortunately, the commit description is just above that, so it can be easy to miss important information! I believe reviewers should always read the commit description first, as it should explain the context of a commit and some relevant design and implementation details. So clicking on a commit should go there first, so it's harder to miss. (Will bug 1248008 make this one moot?)
Summary: Clicking on a commit should go to the comment description → Clicking on a commit should go to the commit description
We intentionally did this in a lot of places because we figured most of the time people wanted to see the actual diff more than the metadata. But yes, I think probably 1248008 will make this bug unnecessary. I'll keep it open until then to see, though.
Depends on: 1248008
You need to log in before you can comment on or make changes to this bug.