1331331 - Add an error state object to MDSM

Status: NEW

(Core :: Audio/Video: Playback, defect, P3)

Description

[JW Wang [:jwwang] [:jw_wang]]

MDSM notify an error when decoding errors are encountered.

http://searchfox.org/mozilla-central/rev/0aed9484bd3e97206fd1949ee4a4992ef300a81f/dom/html/HTMLMediaElement.cpp#5201
However, HTMLMediaElement doesn't shut down MediaDecoder when the error is received.

We want optimize MDSM a little bit in this case by adding an error state to release decoders for better resource usage.

Also since the error is not recoverable, the error state should reject any playback requests like seek, play or pause.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1331331. Part 1 - add ErrorState.

Review commit: https://reviewboard.mozilla.org/r/105670/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/105670/

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1331331. Part 2 - switch to ErrorState in DecodeError().

We also store MediaResult in ErrorState so it can dump the error code/message
in DumpDebugInfo() which is useful in debugging mochitest failures.

Review commit: https://reviewboard.mozilla.org/r/105672/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/105672/