133135 - Warning: reference to undefined property window.arguments

Status: RESOLVED EXPIRED

(SeaMonkey :: Composer, defect)

Description

[timeless]

Warning: reference to undefined property window.arguments
 Source File: 
chrome://editor/content/editor.js
 Line: 139

Comment 1

[timeless]

Attachment: clean up the code

two if blocks, the second one does the right thing, but they're checking the
same boundary conditions. Repeated checks is really bad style.	Then there's
this very awkward approach to getting the charset.

Comment 2

[Doron Rosenberg (IBM)]

+      if (window.arguments.length > 1 && window.arguments[1]) {

Is this realy needed?

Comment 3

[Doron Rosenberg (IBM)]

timeless: do you have an example url for this?

Comment 4

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 75838 [details] [diff] [review]
clean up the code

r=caillon

Comment 5

[Charles Manske]

Comment on attachment 75838 [details] [diff] [review]
clean up the code

btw, the line
WebCompose = true;
is now not needed

Comment 6

[Charles Manske]

Comment on attachment 75838 [details] [diff] [review]
clean up the code

I don't think you should nest:
if (window.arguments.length > 1 && window.arguments[1]) {
inside of:
if (window.arguments.length && window.arguments[0]) {
because you may have a null 1st argument and still include a charset (2nd
argument), no?

Comment 7

[Robert Kaiser]

MASS-CHANGE:
This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state.

If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way.
If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar).
If no action happens within the next few months, we move this bug report to an EXPIRED state.

Query tag for this change: mass-UNCONFIRM-20090614

Comment 8

[Robert Kaiser]

MASS-CHANGE:
This bug report is registered in the SeaMonkey product, but still has no comment since the inception of the SeaMonkey project 5 years ago.

Because of this, we're resolving the bug as EXPIRED.

If you still can reproduce the bug on SeaMonkey 2 or otherwise think it's still valid, please REOPEN it and if it is a platform or toolkit issue, move it to the according component.

Query tag for this change: EXPIRED-20100420