Closed
Bug 133140
Opened 22 years ago
Closed 22 years ago
[HAVE REVIEW] ctcpSend is using 'from' not 'target'
Categories
(Webtools Graveyard :: Mozbot, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
2.4
People
(Reporter: ian, Assigned: ian)
Details
There is a bug in ctcpSend. It should use $event->{'target'} not $event->{'from'}. The patch: sub ctcpSend { my $self = shift; my ($event, $type, $data) = @_; - &::sendmsg($event->{'bot'}, $event->{'from'}, [$type, $data], 'ctcpSend'); + &::sendmsg($event->{'bot'}, $event->{'target'}, [$type, $data],'ctcpSend'); } Makes ctcpSend() send messages to the target, not the originator. This makes it work like say().
Assignee | ||
Comment 1•22 years ago
|
||
This was caught by Cosmic[]shamE on #mozwebtools.
Comment 2•22 years ago
|
||
r=caillon
Assignee | ||
Updated•22 years ago
|
Keywords: review
Summary: [HAVE FIX] ctcpSend is using 'from' not 'target' → [HAVE REVIEW] ctcpSend is using 'from' not 'target'
Updated•22 years ago
|
QA Contact: timeless → kerz
Assignee | ||
Comment 3•22 years ago
|
||
Checked in.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Updated•18 years ago
|
QA Contact: kerz → mozbot
Updated•5 years ago
|
Product: Webtools → Webtools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•