[HAVE REVIEW] ctcpSend is using 'from' not 'target'

RESOLVED FIXED in 2.4

Status

Webtools
Mozbot
P1
normal
RESOLVED FIXED
16 years ago
12 years ago

People

(Reporter: Hixie (not reading bugmail), Assigned: Hixie (not reading bugmail))

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Assignee)

Description

16 years ago
There is a bug in ctcpSend. It should use $event->{'target'} not $event->{'from'}.

The patch:

 sub ctcpSend {
     my $self = shift;
     my ($event, $type, $data) = @_;
-    &::sendmsg($event->{'bot'}, $event->{'from'}, [$type, $data], 'ctcpSend');
+    &::sendmsg($event->{'bot'}, $event->{'target'}, [$type, $data],'ctcpSend');
 }

Makes ctcpSend() send messages to the target, not the originator. This makes it
work like say().
(Assignee)

Comment 1

16 years ago
This was caught by Cosmic[]shamE on #mozwebtools.
Status: NEW → ASSIGNED
Keywords: review
Priority: -- → P1
Target Milestone: --- → Mozbot 2.4
(Assignee)

Updated

16 years ago
Keywords: review
Summary: [HAVE FIX] ctcpSend is using 'from' not 'target' → [HAVE REVIEW] ctcpSend is using 'from' not 'target'

Updated

16 years ago
QA Contact: timeless → kerz
(Assignee)

Comment 3

16 years ago
Checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
QA Contact: kerz → mozbot
You need to log in before you can comment on or make changes to this bug.