1331418 - Migrate Account Target to Swift 3.0

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect, P2)

Description

[Emily Toop (:fluffyemily)]

1. Assign bug for the module to yourself. Ensure all dependent modules are already migrated.
2. Create branch for automatic migration. Only migrate chosen module. Commit. There is no need to review automated migration code.
3. Create branch for manual migration. This is to make reviews easier. Only manual  migrations are to be code reviewed.
4. Select scheme for module. This is to enable each module to be fixed for compilation due to no dependencies outside of module that have not been migrated
5. Fix build errors including porting of Alamofire code to Alamofire 4.0. A migration guide is available.
6. Run tests and ensure they work.

Comment 1

[Emily Toop (:fluffyemily)]

The following automigrations were noted as incomplete or incorrect

FirefoxAccount:
* function names not Swift 3.0 style guide compliant
* migration did not update use of `AnyObject` to `Any` in `asDictionary()` and `fromDictionary()`

FirefoxAccountConfigurationLabels:
* case names were not lowercased

FxAClient10:
* Use of `Foundation.URL` rather than simply `URL`
* function names not Swift 3.0 style guide compliant
* use of `NSMutableURLRequest` in `login` should move to using `URLRequest`

FxADevice:
* function names not Swift 3.0 style guide compliant

FxALoginStateMachine:
* function names not Swift 3.0 style guide compliant

FxAState:
* function names not Swift 3.0 style guide compliant

FxAStateLabel:
* case names were not lowercased

HawkHelper
* class constants should be lowerCamelCase

TokenServerClient:
* function names not Swift 3.0 style guide compliant
* Use of `Foundation.URL` rather than simply `URL`
* in `init` there is no need to cast result of call to `ProductionSync15Configuration().tokenServerEndpointURL` to `URL`

Comment 2

[Emily Toop (:fluffyemily)]

Attachment: Pull request

Manual Migration. This was rebased on top of sleroux's Shared patch. Will need to be rebased before merging.