Closed Bug 1331445 Opened 7 years ago Closed 6 years ago

Intermittent TEST-UNEXPECTED-TIMEOUT | toolkit/components/telemetry/tests/unit/test_TelemetrySend.js | Test timed out

Categories

(Toolkit :: Telemetry, defect, P1)

Product:
Toolkit
Component:
Telemetry
Platform:
Unspecified
Android
Type:
defect

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: intermittent-bug-filer, Assigned: janerik)

References

Details

(Keywords: intermittent-failure, Whiteboard: [measurement:client][stockwell fixed:timing])

Attachments

(1 file)

Disable long-running big ping test on android. r?chutten
1.74 KB, patch
chutten
: review+
Details | Diff | Splinter Review
OS: Unspecified → Android
Whiteboard: [measurement:client]
The new spike was from bug 1450204.
There's been a sudden increase in intermittent timeouts for this test on Android 4.3 API16+ debug. It seems as though it takes a long time for all the telemetry tests to run on this platform, test_TelemetrySession.js for instance took nearly two minutes to complete.

That being said I wasn't expecting to see this clear of an orange spike.

I wonder if bug 1454208 may have something to do with this.
(( the reason I wonder is because it hit the tree just as this spike was getting started (ignoring a weekend slump) ))
Whiteboard: [measurement:client] → [measurement:client][stockwell needswork]
Assignee: nobody → jrediger
Priority: -- → P1
Bug 1369049 made this much worse:

https://treeherder.mozilla.org/#/jobs?repo=autoland&filter-searchStr=android%20debug%20xpcshell&tochange=b507e044f169e46698647db9b6c8df00138817ba&fromchange=5805bf8899b9db1f58a08781e935eb85147dc08e

Perhaps also worth noting that bug 1369049 increased the typical run-time of test_TelemetrySend.js on android/debug by about 50 seconds, bringing the total android/debug run-time for this one test to about 5 minutes. Unless there's a lot of value to running this test on Android/debug, consider skipping it on that platform.
Blocks: 1369049
Bug 1369049 increased the generated payload size to 4 Mb, adding about
50 seconds of runtime for an android/debug build.
This test can be skipped on Android for now.

MozReview-Commit-ID: 5Gn38mcUGTi
Attachment #8975796 - Flags: review?(chutten)
Comment on attachment 8975796 [details] [diff] [review]
Disable long-running big ping test on android. r?chutten

Review of attachment 8975796 [details] [diff] [review]:
-----------------------------------------------------------------

Please file a bug to find a way to add coverage for this case in an Android-friendly manner.
Attachment #8975796 - Flags: review?(chutten) → review+
Blocks: 1461652
Keywords: checkin-needed
Keywords: checkin-needed
No longer blocks: 1461652
See Also: → 1461652
In the last 7 days there are 139 failures.
:janerik, fixing bug 1461652 will also fix this one?
Flags: needinfo?(jrediger)
:narcis: Yes, I'm currently landing that other patch (with the help of :Dexter). I hope to reduce test time with it and thus reducing the failures (if they keep appearing afterwards, we will look into it in more detail and might disable these long-running tests on Android in total)
Flags: needinfo?(jrediger)
(In reply to Jan-Erik Rediger [:janerik] from comment #49)
> :narcis: Yes, I'm currently landing that other patch (with the help of
> :Dexter). I hope to reduce test time with it and thus reducing the failures
> (if they keep appearing afterwards, we will look into it in more detail and
> might disable these long-running tests on Android in total)

Since that patch was landed the failure rate has drasticly decreased: https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?startday=2018-05-17&endday=2018-05-21&tree=trunk&bug=1331445 

Removing [stockwell disable-recommended] based on ^
Whiteboard: [measurement:client][stockwell disable-recommended] → [measurement:client]
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [measurement:client][stockwell disable-recommended] → [measurement:client][stockwell fixed:timing]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: