Closed Bug 1331515 Opened 3 years ago Closed 3 years ago

Reorganize files and namespaces

Categories

(Core :: Graphics: WebRender, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla54

People

(Reporter: nical, Assigned: nical)

References

Details

We have come up with the following scheme:

> gfx
>     webrender_bindings
>         RenderThread.cpp/h
>         WebRenderAPI.cpp/h
>         WebRenderTypes.cpp/h
>         webrender_ffi.h
>         bindings.rs
>     webrender
>         (the webrender crate)
>     webrender_traits
>         (the webrender_traits crate)
>     layers
>         wr
>             WebRenderBidgerParent.cpp/h
>             (other layers specific webrender files such as the Layer classes)

C++ Classes under the webrender_bindings directory are in the mozilla::wr namespace while the ones in the layers directory keep the mozilla::layers namespace.

We should also avoid using the C types that are created for the ffi boundary and use the Moz2D equivalents (for rects etc.). Conversion to and from these ffi types should be done in the wr::WebRenderAPI and wr::DisplayListBuilder. Likewise, in the near future we will use WebRenderAPI and DisplayListBuilder instead of using the ffi functions.
Also anything that needs a webrender-ish prefix should use either "WebRender" or "Wr" (note the case).
Blocks: webrender
Pushed by nsilva@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/161d2bc7eff8
Move webrender wrappers to the webrender_bindings directory. r=gfx?
https://hg.mozilla.org/projects/graphics/rev/42c004f7476a
mozilla/webrender include path. r=gfx?
https://hg.mozilla.org/projects/graphics/rev/ab4b6b978f88
Move webrender_bindings/src/webrender.h to webrender_bindings/webrender_ffi.h. r=gfx?
https://hg.mozilla.org/projects/graphics/rev/e202cf696856
Move some types to the mozilla::wr namespace. r=gfx?
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Assignee: nobody → nical.bugzilla
Status: RESOLVED → REOPENED
Keywords: leave-open
Resolution: FIXED → ---
Pushed by nsilva@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/de76905b9d39
Rename WRRect into WrRect. r=gfx?
https://hg.mozilla.org/projects/graphics/rev/c45c4dd55d21
Rename WRLayoutSize into WrLayoutSize. r=gfx?
https://hg.mozilla.org/projects/graphics/rev/e39c9991dc4f
Rename WRState into WrState. r=gfx?
https://hg.mozilla.org/projects/graphics/rev/a8594012ee72
Rename WRColor into WrColor. r=gfx?
Pushed by nsilva@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/6321610b189b
WR to Wr prefix conversion for more ffi types. r=gfx?
Pushed by nsilva@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/8f272d554787
More WR to Wr prefix conversion. r=gfx?
I think we can close this one now.
Status: REOPENED → RESOLVED
Closed: 3 years ago3 years ago
Keywords: leave-open
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.