Closed
Bug 1331575
Opened 7 years ago
Closed 7 years ago
Explicitly pass lock proofs to TelemetryScalars thread unsafe functions
Categories
(Toolkit :: Telemetry, defect, P3)
Toolkit
Telemetry
Tracking
()
RESOLVED
DUPLICATE
of bug 1362957
Tracking | Status | |
---|---|---|
firefox53 | --- | affected |
People
(Reporter: Dexter, Unassigned)
References
(Blocks 1 open bug)
Details
TelemetryScalar.cpp is prefixing all thread unsafe functions with the "internal_" prefix [1]. After it landed, we decided to change these functions so that their caller has to provide the proof it owns a lock. This basically means we should add a |const StaticMutexAutolock&| parameter to each of the previously mentioned function and that the callers have to change to pass the lock as an argument, as done in TelemetryEvents.cpp [2]. [1] - http://searchfox.org/mozilla-central/search?q=internal_&case=false®exp=false&path=TelemetryScalar.cpp [2] - http://searchfox.org/mozilla-central/rev/c477aa8bd99278962998adba1c5e4b15a02c42c7/toolkit/components/telemetry/TelemetryEvent.cpp#274
Reporter | ||
Updated•7 years ago
|
Reporter | ||
Comment 1•7 years ago
|
||
This was already addressed by a contributor in bug 1362957. Closing this.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•