Closed
Bug 1331580
Opened 7 years ago
Closed 7 years ago
Construct URLSearchParams from record<>
Categories
(Core :: DOM: Core & HTML, defect, P3)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla54
Tracking | Status | |
---|---|---|
firefox54 | --- | fixed |
People
(Reporter: baku, Assigned: baku)
References
Details
(Keywords: dev-doc-complete)
Attachments
(1 file)
4.61 KB,
patch
|
qdot
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1330678 +++ Test: http://w3c-test.org/url/urlsearchparams-constructor.html, landed at https://github.com/w3c/web-platform-tests/pull/4523. Standard: https://github.com/whatwg/url/issues/27, landed at https://github.com/whatwg/url/pull/175.
Comment 1•7 years ago
|
||
The record constructor test had a small bug that is being fixed here: https://github.com/w3c/web-platform-tests/pull/4647.
Comment 2•7 years ago
|
||
Does that mean that once the above PR goes in (which seems to have happened), this bug is invalid?
Flags: needinfo?(annevk)
Comment 3•7 years ago
|
||
No, our IDL doesn't use record<> yet as that isn't implemented per dependency bug 1330699. You'll note that we still fail those tests.
Flags: needinfo?(annevk)
Comment 4•7 years ago
|
||
ok, thanks for the clarification!
Updated•7 years ago
|
Priority: -- → P3
Updated•7 years ago
|
Keywords: dev-doc-needed
Assignee | ||
Comment 5•7 years ago
|
||
Assignee: nobody → amarchesini
Attachment #8842843 -
Flags: review?(kyle)
Updated•7 years ago
|
Attachment #8842843 -
Flags: review?(kyle) → review+
Pushed by amarchesini@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/ee9c3cd7d55f Construct URLSearchParams from record<>, r=qdot
Comment 7•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/ee9c3cd7d55f
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Comment 8•7 years ago
|
||
Documented: https://developer.mozilla.org/en-US/docs/Web/API/URLSearchParams https://developer.mozilla.org/en-US/docs/Web/API/URLSearchParams/URLSearchParams Release notes updated: https://developer.mozilla.org/en-US/Firefox/Releases/54#DOM_HTML_DOM
Keywords: dev-doc-needed → dev-doc-complete
Comment 9•7 years ago
|
||
Did this add the test I asked for in bug 1330692 comment 2?
Flags: needinfo?(amarchesini)
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•