Closed Bug 1331593 Opened 3 years ago Closed 1 year ago

[Static Analysis][ Result is not floating-point] In function InitLowFrequencyCorrectionRanges

Categories

(Core :: WebRTC, defect, P3)

defect

Tracking

()

RESOLVED FIXED
Tracking Status
firefox53 --- affected

People

(Reporter: andi, Assigned: andi)

References

(Blocks 1 open bug)

Details

(Keywords: coverity, Whiteboard: CID 1398321)

The Static Analysis tool Coverity detected that the result of the operation is not floating point:


>>void NonlinearBeamformer::InitLowFrequencyCorrectionRanges() {
>>  low_mean_start_bin_ = Round(kLowMeanStartHz * kFftSize / sample_rate_hz_);
>>  low_mean_end_bin_ = Round(kLowMeanEndHz * kFftSize / sample_rate_hz_);

For this i've uploaded a patch upstream: https://codereview.webrtc.org/2634283002/

This bug has been added to be able to track the progress of that issue and in order to correlate with Coverity scans.
Rank: 25
Priority: -- → P2
This has been merged into webrtc master branch.
https://chromium.googlesource.com/external/webrtc/+/4ed18da9903f6fdb4a502def3e0e6f0408463940
This bug should be closed when the new webrtc source is integrated in our tree.
When do you think that the next merge will be pulled to our tree?
Flags: needinfo?(rjesup)
(In reply to Andi-Bogdan Postelnicu [:andi] from comment #2)
> When do you think that the next merge will be pulled to our tree?

Bug 1341285 - work is occurring on a patch repo; right now it's running on linux, windows and android, with mac soon, then quash oranges and land, so within the next week or two.
Flags: needinfo?(rjesup)
Mass change P2->P3 to align with new Mozilla triage process.
Priority: P2 → P3

Closing this as we've updated webrtc.

Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.