[Static Analysis][ Result is not floating-point] In function InitLowFrequencyCorrectionRanges

NEW
Assigned to

Status

()

Core
WebRTC
P3
normal
Rank:
25
a year ago
4 months ago

People

(Reporter: andi, Assigned: andi)

Tracking

(Blocks: 1 bug, {coverity})

Trunk
coverity
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox53 affected)

Details

(Whiteboard: CID 1398321)

(Assignee)

Description

a year ago
The Static Analysis tool Coverity detected that the result of the operation is not floating point:


>>void NonlinearBeamformer::InitLowFrequencyCorrectionRanges() {
>>  low_mean_start_bin_ = Round(kLowMeanStartHz * kFftSize / sample_rate_hz_);
>>  low_mean_end_bin_ = Round(kLowMeanEndHz * kFftSize / sample_rate_hz_);

For this i've uploaded a patch upstream: https://codereview.webrtc.org/2634283002/

This bug has been added to be able to track the progress of that issue and in order to correlate with Coverity scans.

Updated

a year ago
Rank: 25
Priority: -- → P2
(Assignee)

Comment 1

9 months ago
This has been merged into webrtc master branch.
https://chromium.googlesource.com/external/webrtc/+/4ed18da9903f6fdb4a502def3e0e6f0408463940
This bug should be closed when the new webrtc source is integrated in our tree.
(Assignee)

Comment 2

9 months ago
When do you think that the next merge will be pulled to our tree?
Flags: needinfo?(rjesup)
(In reply to Andi-Bogdan Postelnicu [:andi] from comment #2)
> When do you think that the next merge will be pulled to our tree?

Bug 1341285 - work is occurring on a patch repo; right now it's running on linux, windows and android, with mac soon, then quash oranges and land, so within the next week or two.
Flags: needinfo?(rjesup)

Updated

9 months ago
Depends on: 1341285
Mass change P2->P3 to align with new Mozilla triage process.
Priority: P2 → P3
You need to log in before you can comment on or make changes to this bug.