Migrate XCGLogger to swift 3.0 compatible version

RESOLVED FIXED

Status

()

P2
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: fluffyemily, Assigned: fluffyemily)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [MobileCore])

Attachments

(1 attachment)

55 bytes, text/x-github-pull-request
sleroux
: review+
Details | Review | Splinter Review
(Assignee)

Description

2 years ago
Currently we are using a fork of XCGLogger (https://github.com/thebnich/XCGLogger) because there were some I/O issues around logging that required a swift try/catch block.

1. Check that the patch has been accepted into XCGLogger main tree (https://github.com/DaveWoodCom/XCGLogger)
2. If it has, update the dependency imported via Carthage to use https://github.com/DaveWoodCom/XCGLogger
3. If not, migrate our fork to use Swift 3.0, tag, release and update Carthage version number
(Assignee)

Updated

2 years ago
Blocks: 1323459
Whiteboard: [MobileCore]
Priority: -- → P2
(Assignee)

Updated

2 years ago
Assignee: nobody → etoop
Status: NEW → ASSIGNED
(Assignee)

Comment 1

2 years ago
Created attachment 8830251 [details] [review]
Pull request
Attachment #8830251 - Flags: review?(jhugman)
(Assignee)

Comment 2

2 years ago
Comment on attachment 8830251 [details] [review]
Pull request

[
Attachment #8830251 - Flags: review?(sleroux)
Attachment #8830251 - Flags: review?(sleroux) → review+
(Assignee)

Updated

2 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Iteration: --- → 1.14
(Assignee)

Updated

2 years ago
Attachment #8830251 - Flags: review?(jhugman)
You need to log in before you can comment on or make changes to this bug.