Closed Bug 1331596 Opened 9 years ago Closed 9 years ago

Migrate XCGLogger to swift 3.0 compatible version

Categories

(Firefox for iOS :: General, defect, P2)

Other
iOS
defect

Tracking

()

RESOLVED FIXED
Iteration:
1.14

People

(Reporter: fluffyemily, Assigned: fluffyemily)

References

Details

(Whiteboard: [MobileCore])

Attachments

(1 file)

55 bytes, text/x-github-pull-request
sleroux
: review+
Details | Review
Currently we are using a fork of XCGLogger (https://github.com/thebnich/XCGLogger) because there were some I/O issues around logging that required a swift try/catch block. 1. Check that the patch has been accepted into XCGLogger main tree (https://github.com/DaveWoodCom/XCGLogger) 2. If it has, update the dependency imported via Carthage to use https://github.com/DaveWoodCom/XCGLogger 3. If not, migrate our fork to use Swift 3.0, tag, release and update Carthage version number
Blocks: 1323459
Whiteboard: [MobileCore]
Priority: -- → P2
Assignee: nobody → etoop
Status: NEW → ASSIGNED
Attached file Pull request
Attachment #8830251 - Flags: review?(jhugman)
Comment on attachment 8830251 [details] [review] Pull request [
Attachment #8830251 - Flags: review?(sleroux)
Attachment #8830251 - Flags: review?(sleroux) → review+
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Iteration: --- → 1.14
Attachment #8830251 - Flags: review?(jhugman)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: