Closed Bug 1331604 Opened 5 years ago Closed 5 years ago
Upgrade kinto libraries (support of Retry-After headers)
Currently, if the server fails to process the request, the client will throw and give up. With kinto.js v7.0.0 and kinto-http.js v2.7.0, if server provides the `Retry-After` header, the client will wait and retry (once by default).
Attachment #8827439 - Attachment is obsolete: true
Comment on attachment 8827440 [details] Bug 1331604 - Minor style and idiom changes () https://reviewboard.mozilla.org/r/105128/#review105930
Attachment #8827440 - Flags: review?(mgoodwin) → review+
Attachment #8827438 - Flags: review?(eglassercamp)
Comment on attachment 8827438 [details] Bug 1331604 - Upgrade kinto libraries () https://reviewboard.mozilla.org/r/105124/#review105968 Looks fine to me. This is a huge jump, from kinto-http.js 2.0.0 to 2.6.0, and a lot of changes are due to the added support for the attachment plugin. Note that I don't have L3 access, so my review isn't sufficient to autoland this.
Attachment #8827438 - Flags: review?(eglassercamp) → review+
Comment on attachment 8827438 [details] Bug 1331604 - Upgrade kinto libraries () https://reviewboard.mozilla.org/r/105124/#review106138
Attachment #8827438 - Flags: review+
I had to r+ this in MozReview to work around Autoland not seeing it as being ready to land. That said, Autoland couldn't rebase this for pushing, so you'll need to update the patch and re-request checkin.
Ryan, I'm sorry for the trouble :/ I rebased and fixed, it should be all good now.
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/99bd07f1c686 Upgrade kinto libraries (r=glasserc,RyanVM) https://hg.mozilla.org/integration/autoland/rev/84a59e9496ed Minor style and idiom changes (r=mgoodwin)
You need to log in before you can comment on or make changes to this bug.