Closed Bug 1331604 Opened 5 years ago Closed 5 years ago

Upgrade kinto libraries (support of Retry-After headers)

Categories

(Toolkit :: Blocklist Policy Requests, defect)

Product:
Toolkit
Component:
Blocklist Policy Requests
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla53
Tracking Flags:
Tracking Status
firefox53 --- fixed

People

(Reporter: leplatrem, Assigned: leplatrem)

Details

Attachments

(2 files, 1 obsolete file)

Bug 1331604 - Upgrade kinto libraries ()
59 bytes, text/x-review-board-request
glasserc
: review+
Details
Bug 1331604 - Minor style and idiom changes ()
59 bytes, text/x-review-board-request
mgoodwin
: review+
Details 
Currently, if the server fails to process the request, the client will throw and give up. 

With kinto.js v7.0.0 and kinto-http.js v2.7.0, if server provides the `Retry-After` header, the client will wait and retry (once by default).
Attachment #8827439 - Attachment is obsolete: true
Comment on attachment 8827440 [details]
Bug 1331604 - Minor style and idiom changes ()

https://reviewboard.mozilla.org/r/105128/#review105930
Attachment #8827440 - Flags: review?(mgoodwin) → review+
Attachment #8827438 - Flags: review?(eglassercamp)
Assignee: nobody → mathieu
Comment on attachment 8827438 [details]
Bug 1331604 - Upgrade kinto libraries ()

https://reviewboard.mozilla.org/r/105124/#review105968

Looks fine to me. This is a huge jump, from kinto-http.js 2.0.0 to 2.6.0, and a lot of changes are due to the added support for the attachment plugin. Note that I don't have L3 access, so my review isn't sufficient to autoland this.
Attachment #8827438 - Flags: review?(eglassercamp) → review+
Keywords: checkin-needed
I had to r+ this in MozReview to work around Autoland not seeing it as being ready to land. That said, Autoland couldn't rebase this for pushing, so you'll need to update the patch and re-request checkin.
Keywords: checkin-needed
Ryan, I'm sorry for the trouble :/ 
I rebased and fixed, it should be all good now.
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/99bd07f1c686
Upgrade kinto libraries (r=glasserc,RyanVM)
https://hg.mozilla.org/integration/autoland/rev/84a59e9496ed
Minor style and idiom changes (r=mgoodwin)
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/99bd07f1c686
https://hg.mozilla.org/mozilla-central/rev/84a59e9496ed
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.