Closed
Bug 1331604
Opened 4 years ago
Closed 4 years ago
Upgrade kinto libraries (support of Retry-After headers)
Categories
(Toolkit :: Blocklist Policy Requests, defect)
Toolkit
Blocklist Policy Requests
Tracking
()
RESOLVED
FIXED
mozilla53
Tracking | Status | |
---|---|---|
firefox53 | --- | fixed |
People
(Reporter: leplatrem, Assigned: leplatrem)
Details
Attachments
(2 files, 1 obsolete file)
Currently, if the server fails to process the request, the client will throw and give up. With kinto.js v7.0.0 and kinto-http.js v2.7.0, if server provides the `Retry-After` header, the client will wait and retry (once by default).
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Updated•4 years ago
|
Attachment #8827439 -
Attachment is obsolete: true
Comment 6•4 years ago
|
||
mozreview-review |
Comment on attachment 8827440 [details] Bug 1331604 - Minor style and idiom changes () https://reviewboard.mozilla.org/r/105128/#review105930
Attachment #8827440 -
Flags: review?(mgoodwin) → review+
Assignee | ||
Updated•4 years ago
|
Attachment #8827438 -
Flags: review?(eglassercamp)
Assignee | ||
Updated•4 years ago
|
Assignee: nobody → mathieu
Comment 7•4 years ago
|
||
mozreview-review |
Comment on attachment 8827438 [details] Bug 1331604 - Upgrade kinto libraries () https://reviewboard.mozilla.org/r/105124/#review105968 Looks fine to me. This is a huge jump, from kinto-http.js 2.0.0 to 2.6.0, and a lot of changes are due to the added support for the attachment plugin. Note that I don't have L3 access, so my review isn't sufficient to autoland this.
Attachment #8827438 -
Flags: review?(eglassercamp) → review+
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Updated•4 years ago
|
Keywords: checkin-needed
Comment 10•4 years ago
|
||
mozreview-review |
Comment on attachment 8827438 [details] Bug 1331604 - Upgrade kinto libraries () https://reviewboard.mozilla.org/r/105124/#review106138
Attachment #8827438 -
Flags: review+
Comment 11•4 years ago
|
||
I had to r+ this in MozReview to work around Autoland not seeing it as being ready to land. That said, Autoland couldn't rebase this for pushing, so you'll need to update the patch and re-request checkin.
Keywords: checkin-needed
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 14•4 years ago
|
||
Ryan, I'm sorry for the trouble :/ I rebased and fixed, it should be all good now.
Assignee | ||
Updated•4 years ago
|
Keywords: checkin-needed
Comment 15•4 years ago
|
||
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/autoland/rev/99bd07f1c686 Upgrade kinto libraries (r=glasserc,RyanVM) https://hg.mozilla.org/integration/autoland/rev/84a59e9496ed Minor style and idiom changes (r=mgoodwin)
Keywords: checkin-needed
Comment 16•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/99bd07f1c686 https://hg.mozilla.org/mozilla-central/rev/84a59e9496ed
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in
before you can comment on or make changes to this bug.
Description
•