1331643 - ISE when adding two document tags that only differ in capitalization

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: Tags / flags, defect)

Description

[John Whitlock [:jwhitlock]]

What did you do?
================
1. Edit https://developer.allizom.org/en-US/docs/user:jwhitlock$edit
2. Add tags "TestTag" and "testtag"
3. Save 

What happened?
==============
An Internal Server Error occurs


What should have happened?
==========================
Only one tag should have been created, added


Is there anything else we should know?
======================================
This began after the unique index was added in bug 1293749.  Because of how tags are implemented in revisions, it may not require a user explicitly adds the tags, but instead makes a content edit without removing duplicate tags.

Comment 1

[[github robot]]

Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/a1bcbeaf4093af35637ae6fbbfe732b47a578f80
bug 1331643: TAGGIT_CASE_INSENSITIVE=True

Tell django-taggit to use case insensitive lookups for existing tags.
We're using MySQL with a case insensitive collation, so this is already
done at the database level, but this may help the code work correctly
with the database.

https://github.com/mozilla/kuma/commit/c18886dcd532af9d16e675fb1d2e985466301523
bug 1331643: Test adding duplicate document tags

Add tests for bug 1331643, where Revisions with existing "duplicate"
tags (equal after adjusting for case insensitivity) set the Document
tags.

https://github.com/mozilla/kuma/commit/0f972a3e54c249211a449875302ac23878e99651
Merge pull request #4103 from jwhitlock/taggit_ci_1331643

bug 1331643, 1330357: Avoid duplicate tags with TAGGIT_CASE_INSENSITIVE=True

Comment 2

[John Whitlock [:jwhitlock]]

Pushed to stage and production. Confirmed that mixed case tags do not cause an ISE.