mscom::RegisterProxy needs to be able to register stuff contained within xul.dll

RESOLVED FIXED in Firefox 54

Status

()

Core
IPC
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: aklotz, Assigned: aklotz)

Tracking

Trunk
mozilla54
Unspecified
Windows
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox53 affected, firefox54 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

a year ago
We currently support loading proxies from other dlls, but we don't support loading proxies from within our own module.
Comment hidden (mozreview-request)
Blocks: 1288839

Comment 2

a year ago
mozreview-review
Comment on attachment 8827623 [details]
Bug 1331687: Overload mscom::RegisterProxy to allow proxy registration from within xul.dll itself;

https://reviewboard.mozilla.org/r/105240/#review107476

::: ipc/mscom/Registration.cpp:116
(Diff revision 1)
> +static bool
> +RegisterPSClsids(const ProxyFileInfo** aProxyInfo, const CLSID* aProxyClsid)
> +{
> +  while (*aProxyInfo) {
> +    const ProxyFileInfo& curInfo = **aProxyInfo;
> +    for (unsigned short i = 0, e = curInfo.TableSize; i < e; ++i) {

s/i/idx to address a personal pet peeve. I'd also suggest something other than 'e' for the other var, like maybe 'size'.
Attachment #8827623 - Flags: review?(jmathies) → review+
Comment hidden (mozreview-request)

Comment 4

a year ago
Pushed by aklotz@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/97795bcd29b1
Overload mscom::RegisterProxy to allow proxy registration from within xul.dll itself; r=jimm

Comment 5

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/97795bcd29b1
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.