Closed Bug 1331723 Opened 3 years ago Closed 2 years ago

Fix Windows packaging of Instantbird

Categories

(Instantbird :: Other, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: clokep, Assigned: clokep)

Details

Attachments

(1 file)

Attached patch Patch v1Splinter Review
Due to duplicates changes.

This patch gets packaging to work, but I don't think is completely correct.
Attachment #8827606 - Flags: feedback?(florian)
Attachment #8827606 - Flags: feedback?(aleth)
Comment on attachment 8827606 [details] [diff] [review]
Patch v1

Review of attachment 8827606 [details] [diff] [review]:
-----------------------------------------------------------------

::: im/themes/jar.mn
@@ -117,5 @@
>  #ifdef XP_WIN
>  *	skin/classic/aero/instantbird/accounts.css		(accounts-aero.css)
> -	skin/classic/aero/instantbird/alert.css
> -*	skin/classic/aero/instantbird/richlistbox.css
> -*	skin/classic/aero/instantbird/accountWizard.css

Is there a fallback for these or why can you just remove them?
Attachment #8827606 - Flags: feedback?(aleth)
(In reply to aleth [:aleth] from comment #1)
> Is there a fallback for these or why can you just remove them?

These were the same for aero and non-aero, but I think that aero isn't used anymore so I can just remove them?
(In reply to Patrick Cloke [:clokep] from comment #2)
> I think that aero isn't used anymore so I can just remove them?

aero is used, unless someone removes:
http://searchfox.org/comm-central/source/im/themes/jar.mn#11
% skin instantbird classic/1.0 %skin/classic/aero/instantbird/ os=WINNT osversion>=6

It's the non-aero version that isn't used any more, if we dropped support for Windows XP.
Attachment #8827606 - Flags: feedback?(florian)
WONTFIX
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.