Use menulist-powered <select> dropdown by default in non-e10s

ASSIGNED
Assigned to

Status

()

Firefox
General
ASSIGNED
3 months ago
20 days ago

People

(Reporter: mconley, Assigned: mconley)

Tracking

(Depends on: 1 bug, Blocks: 2 bugs)

Firefox Tracking Flags

(Not tracked)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

3 months ago
This capability was added in bug 1300784, but is disabled by default behind the dom.select_popup_in_parent.enabled pref.

When we're good and ready, we should turn this thing on for everybody so that all users are on the same codepath.
(Assignee)

Comment 1

3 months ago
This is blocked on fixing a perma-failure we had on Linux 64 debug bc1:

TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_selectpopup.js | Popup top position in within browser area -
(Assignee)

Updated

3 months ago
Blocks: 1300483
Comment hidden (mozreview-request)
(Assignee)

Comment 3

2 months ago
The permafailure I mentioned in comment 1 appears to not be around anymore. The test does infrequently orange if I enable it on Linux64 debug, so I've kept it disabled there (bug 1329991).

Comment 4

2 months ago
mozreview-review
Comment on attachment 8836976 [details]
Bug 1331725 - Use menulist powered <select> dropdown by default for non-e10s.

https://reviewboard.mozilla.org/r/112274/#review113924
Attachment #8836976 - Flags: review?(jaws) → review+
Assignee: nobody → mconley
Status: NEW → ASSIGNED
Note that this patch will have to be rebased on top of the patch that landed in bug 1339966, which moved the pref to sit next to the other select prefs.

Comment 6

2 months ago
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0583ceac0df9
Use menulist powered <select> dropdown by default for non-e10s. r=jaws
Backed out for failing devtools/client/animationinspector/test/browser_animation_timeline_rate_selector.js:

https://hg.mozilla.org/integration/autoland/rev/31fedf253dbf78d6ce4042d3b65f80285cf5253d

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=0583ceac0df95dd599789dc969879317ff72979a&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=78418797&repo=autoland

[task 2017-02-17T19:56:50.981532Z] 19:56:50     INFO - TEST-START | devtools/client/animationinspector/test/browser_animation_timeline_rate_selector.js
[task 2017-02-17T19:58:21.020176Z] 19:58:21     INFO - TEST-INFO | started process screentopng
[task 2017-02-17T19:58:21.788133Z] 19:58:21     INFO - TEST-INFO | screentopng: exit 0
[task 2017-02-17T19:58:21.789081Z] 19:58:21     INFO - Buffered messages logged at 19:56:50
[task 2017-02-17T19:58:21.789145Z] 19:58:21     INFO - Entering test bound 
[task 2017-02-17T19:58:21.790228Z] 19:58:21     INFO - Buffered messages logged at 19:56:51
[task 2017-02-17T19:58:21.790843Z] 19:58:21     INFO - Adding a new tab with URL: http://example.com/browser/devtools/client/animationinspector/test/doc_simple_animation.html
[task 2017-02-17T19:58:21.791969Z] 19:58:21     INFO - Tab added and finished loading
[task 2017-02-17T19:58:21.794574Z] 19:58:21     INFO - Loading the helper frame script chrome://mochitests/content/browser/devtools/client/animationinspector/test/doc_frame_script.js
[task 2017-02-17T19:58:21.796040Z] 19:58:21     INFO - Loading the helper frame script chrome://devtools/content/shared/frame-script-utils.js
[task 2017-02-17T19:58:21.797705Z] 19:58:21     INFO - Opening the inspector
[task 2017-02-17T19:58:21.799394Z] 19:58:21     INFO - Opening the toolbox
[task 2017-02-17T19:58:21.801133Z] 19:58:21     INFO - Buffered messages logged at 19:56:54
[task 2017-02-17T19:58:21.803281Z] 19:58:21     INFO - Toolbox opened and focused
[task 2017-02-17T19:58:21.804722Z] 19:58:21     INFO - Waiting for actor features to be detected
[task 2017-02-17T19:58:21.806175Z] 19:58:21     INFO - Selecting the animationinspector sidebar
[task 2017-02-17T19:58:21.807948Z] 19:58:21     INFO - Waiting for the inspector and sidebar to be ready
[task 2017-02-17T19:58:21.809486Z] 19:58:21     INFO - Buffered messages logged at 19:56:55
[task 2017-02-17T19:58:21.811018Z] 19:58:21     INFO - Waiting for the animation controller and panel to be ready
[task 2017-02-17T19:58:21.812757Z] 19:58:21     INFO - TEST-PASS | devtools/client/animationinspector/test/browser_animation_timeline_rate_selector.js | The rate selector exists - 
[task 2017-02-17T19:58:21.814177Z] 19:58:21     INFO - Change all of the current animations' rates to 0.5
[task 2017-02-17T19:58:21.815674Z] 19:58:21     INFO - Buffered messages logged at 19:57:36
[task 2017-02-17T19:58:21.816995Z] 19:58:21     INFO - Longer timeout required, waiting longer...  Remaining timeouts: 1
[task 2017-02-17T19:58:21.818846Z] 19:58:21     INFO - Buffered messages finished
[task 2017-02-17T19:58:21.820429Z] 19:58:21     INFO - TEST-UNEXPECTED-FAIL | devtools/client/animationinspector/test/browser_animation_timeline_rate_selector.js | Test timed out -
Flags: needinfo?(mconley)
More failures:
M(8) https://treeherder.mozilla.org/logviewer.html#?job_id=78420788&repo=autoland
M(c3) https://treeherder.mozilla.org/logviewer.html#?job_id=78421468&repo=autoland

Please check this push for more failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=fd6b2015612733fc57c92b7e6bcc8cbdf23fe81a&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable (runs more tests)
(Assignee)

Comment 9

2 months ago
Thanks for the backout, will investigate soon.
Flags: needinfo?(mconley)
Hey Mike, were you able to make any progress on this? Perhaps we should just disable the test in the specific environment where it's failing.
Flags: needinfo?(mconley)
Blocks: 1337034
(Assignee)

Comment 11

a month ago
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #10)
> Hey Mike, were you able to make any progress on this? Perhaps we should just
> disable the test in the specific environment where it's failing.

Unfortunately, it's a whole slew of tests, I'm afraid:

[ ] layout/forms/test/test_bug348236.html
[ ] layout/forms/test/test_bug903715.html
[ ] layout/forms/test/test_bug961363.html
[ ] layout/forms/test/test_select_vertical.html 
[ ] accessible/tests/mochitest/actions/test_select.html | Unique type focus event was handled.
[ ] accessible/tests/mochitest/actions/test_tree.xul | Unique type focus event was handled.
[ ] accessible/tests/mochitest/actions/test_treegrid.xul | Unique type focus event was handled.
[ ] accessible/tests/mochitest/aom/test_general.html | Unique type focus event was handled.
[ ] accessible/tests/mochitest/attributes/test_obj.html | Unique type focus event was handled.
[ ] accessible/tests/mochitest/attributes/test_obj_css.html | Unique type focus event was handled.
[ ] /accessible/tests/mochitest/attributes/test_obj_css.xul | Unique type focus event was handled.
[ ] /accessible/tests/mochitest/attributes/test_obj_group.html | Unique type focus event was handled.
[ ] accessible/tests/mochitest/attributes/test_obj_group.xul | Unique type focus event was handled.
[ ] accessible/tests/mochitest/attributes/test_obj_group_tree.xul | Unique type focus event was handled.
[ ] accessible/tests/mochitest/attributes/test_tag.html | Unique type focus event was handled.
[ ] accessible/tests/mochitest/attributes/test_xml-roles.html | Unique type focus event was handled.
[ ] /accessible/tests/mochitest/bounds/test_list.html | Unique type focus event was handled.
[ ] accessible/tests/mochitest/bounds/test_select.html | Unique type focus event was handled.
[ ] accessible/tests/mochitest/bounds/test_zoom.html | Unique type focus event was handled.
[ ] accessible/tests/mochitest/bounds/test_zoom_text.html | Unique type focus event was handled.
[ ] accessible/tests/mochitest/editabletext/test_1.html | Unique type focus event was handled.
[ ] accessible/tests/mochitest/editabletext/test_2.html | Unique type focus event was handled.
[ ] accessible/tests/mochitest/elm/test_HTMLSpec.html | Unique type focus event was handled.
[ ] accessible/tests/mochitest/elm/test_MathMLSpec.html | Unique type focus event was handled.
[ ] accessible/tests/mochitest/elm/test_canvas.html | Unique type focus event was handled.
[ ] accessible/tests/mochitest/elm/test_figure.html | Unique type focus event was handled.
[ ] accessible/tests/mochitest/elm/test_listbox.xul | Unique type focus event was handled.
[ ] accessible/tests/mochitest/elm/test_nsApplicationAcc.html | Unique type focus event was handled.
[ ] accessible/tests/mochitest/elm/test_plugin.html | Unique type focus event was handled.
[ ] accessible/tests/mochitest/elm/test_shadowroot.html | Unique type focus event was handled.
[ ] /accessible/tests/mochitest/events/test_aria_alert.html | Unique type focus event was handled.
[ ] accessible/tests/mochitest/events/test_aria_menu.html | Unique type focus event was handled.
[ ] /accessible/tests/mochitest/events/test_aria_objattr.html | Unique type focus event was handled.
[ ] accessible/tests/mochitest/events/test_aria_owns.html | Unique type focus event was handled.
[ ] accessible/tests/mochitest/events/test_aria_statechange.html | Unique type focus event was handled.
[ ] accessible/tests/mochitest/events/test_attrs.html | Unique type focus event was handled.
[ ] /accessible/tests/mochitest/events/test_bug1322593-2.html | Unique type focus event was handled.
[ ] accessible/tests/mochitest/events/test_bug1322593.html | Unique type focus event was handled.
[ ] accessible/tests/mochitest/events/test_caretmove.html | Unique type focus event was handled.
[ ] layout/forms/test/test_bug665540.html | Test timed out.
[ ] devtools/client/animationinspector/test/browser_animation_timeline_rate_selector.js | Test timed out -
Flags: needinfo?(mconley)
(Assignee)

Comment 12

a month ago
And to be clear, no, beyond finding that these tests are broken, I've not done anything else to push this forward.

I'm happy to give this bug up if someone has more time to fix the breakage.

Is that someone you, jaws? :)
Flags: needinfo?(jaws)
Unfortunately I don't have the available time. I am trying to put my notes on the bugs blocking bug  	1332301 so that the work can be picked up by someone else once we can get some prioritized time for it. This bug may fix/obsolete itself with time as we migrate more users off of e10s anyways.
Flags: needinfo?(jaws)

Updated

a month ago
Depends on: 1349748

Updated

a month ago
Depends on: 1349984

Updated

27 days ago
Depends on: 1351051
I duped bug 1351051 to bug 1309271. I think the upshot here is that the menulist-powered <select> dropdown has known, existing focus-related accessibility issues that are not present in the legacy/non-e10s implementation. Sharing the new implementation across both e10s and non-e10s would constitute a fairly serious a11y regression until 1309271 is fixed.
Depends on: 1309271
You need to log in before you can comment on or make changes to this bug.