childCrashNotifyPipe not freed in XP_MACOSX case

RESOLVED FIXED in Firefox 55

Status

()

Toolkit
Crash Reporting
RESOLVED FIXED
11 months ago
7 months ago

People

(Reporter: tromey, Assigned: tromey)

Tracking

unspecified
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

11 months ago
From https://bugzilla.mozilla.org/show_bug.cgi?id=1060419#c139.

nsExceptionHandler sets childCrashNotifyPipe in the XP_MACOSX case here:

https://dxr.mozilla.org/mozilla-central/rev/3e275d37a06236981bff399b7d7aa0646be3fee7/toolkit/crashreporter/nsExceptionHandler.cpp#3531

This is also done for XP_WIN as well.  For this case it is freed:

https://dxr.mozilla.org/mozilla-central/rev/3e275d37a06236981bff399b7d7aa0646be3fee7/toolkit/crashreporter/nsExceptionHandler.cpp#3582

.. this freeing is not done for XP_MACOSX, but should be.
(Assignee)

Updated

8 months ago
Assignee: nobody → ttromey
Comment hidden (mozreview-request)
Comment on attachment 8864292 [details]
Bug 1331766 - free childCrashNotifyPipe on XP_MACOSX;

https://reviewboard.mozilla.org/r/135916/#review138974
Attachment #8864292 - Flags: review?(nfroyd) → review+

Comment 3

8 months ago
Pushed by ttromey@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4e62fbf8f6ef
free childCrashNotifyPipe on XP_MACOSX; r=froydnj

Comment 4

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/4e62fbf8f6ef
Status: NEW → RESOLVED
Last Resolved: 7 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.