Closed Bug 1331795 Opened 3 years ago Closed 3 years ago

Switch pdfjs zoom test to use data-page-number attribute. issue#5897

Categories

(Firefox :: PDF Viewer, defect, minor)

defect
Not set
minor

Tracking

()

RESOLVED FIXED
Firefox 53
Tracking Status
firefox53 --- fixed

People

(Reporter: dhouse, Unassigned)

Details

Attachments

(1 file, 1 obsolete file)

Re: the pdf.js issue, https://github.com/mozilla/pdf.js/issues/5897, the moz-cental test of pdf.js zooming needs to use the data-page-number attribute instead of the page div id.

browser/extensions/pdfjs/test/browser_pdfjs_zoom.js
Attachment #8827682 - Flags: review?(ydelendik)
Attachment #8827682 - Attachment is obsolete: true
Attachment #8827682 - Flags: review?(ydelendik)
Comment on attachment 8827684 [details]
Bug 1331795: pdfjs test, switch selector to use page number attribute

https://reviewboard.mozilla.org/r/105310/#review106144

Looks good. Thank you for the patch.
Attachment #8827684 - Flags: review?(ydelendik) → review+
Assignee: nobody → dhouse
Status: NEW → ASSIGNED
Keywords: checkin-needed
Comment on attachment 8827684 [details]
Bug 1331795: pdfjs test, switch selector to use page number attribute

https://reviewboard.mozilla.org/r/105310/#review106302
Comment on attachment 8827684 [details]
Bug 1331795: pdfjs test, switch selector to use page number attribute

https://reviewboard.mozilla.org/r/105310/#review106304
Attachment #8827684 - Flags: review+
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/5999113009c3
pdfjs test, switch selector to use page number attribute r=RyanVM,yury
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/5999113009c3
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
You need to log in before you can comment on or make changes to this bug.