1331818 - Disabled "Terminate" button in about:support if no GPU process is running

Status: NEW

(Core :: Graphics, enhancement, P5)

Description

[u279076]

Currently, if a user has a GPU process running initially we display a "Terminate GPU Process" button in about:support|Graphics. If the user clicks that button the process is terminated and, in theory, a new process would spawn. 

Currently we default max_restarts so that a new process is not spawned on termination but the button in about:support remains enabled. This is a minor UX nit but I'd like to suggest we disable this button (ie. grey it out) if a GPU process is not running.

Flagging :dvander since we talked about this via email.

Comment 1

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: bug1331818.patch

Grey the button when DisableGPUProcess() is called.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/74d2f566ed65
Disabled "Terminate" button in about:support if no GPU process is running. (bug 1331818, r=gwright)

Comment 3

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a5fc021fd3f5
Backed out changeset 74d2f566ed65 for memory leaks in url = about:support

Comment 4

[Carsten Book [:Tomcat]]

bscked out for leaks like https://treeherder.mozilla.org/logviewer.html#?job_id=74717714&repo=mozilla-inbound

Comment 5

[David Anderson [:dvander] - inactive, e-mail if emergency]

I didn't see leaks on try, but it's probably due to me not removing an Observer. Another try run with a fix: https://treeherder.mozilla.org/#/jobs?repo=try&revision=78346148b5661cf91509ef7f5842476e197d1474

It looks ok so I'll push again when the tree is open.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/959e338a566a
Disabled "Terminate" button in about:support if no GPU process is running. (bug 1331818, r=gwright)

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out again for leaks like https://treeherder.mozilla.org/logviewer.html#?job_id=75274142&repo=mozilla-inbound

https://hg.mozilla.org/integration/mozilla-inbound/rev/dde8ef8cf38e

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.