Open Bug 1331818 Opened 3 years ago Updated 3 years ago

Disabled "Terminate" button in about:support if no GPU process is running

Categories

(Core :: Graphics, enhancement, P5)

enhancement

Tracking

()

ASSIGNED

People

(Reporter: ashughes, Assigned: dvander)

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file)

Currently, if a user has a GPU process running initially we display a "Terminate GPU Process" button in about:support|Graphics. If the user clicks that button the process is terminated and, in theory, a new process would spawn. 

Currently we default max_restarts so that a new process is not spawned on termination but the button in about:support remains enabled. This is a minor UX nit but I'd like to suggest we disable this button (ie. grey it out) if a GPU process is not running.

Flagging :dvander since we talked about this via email.
Flags: needinfo?(dvander)
Priority: -- → P5
Whiteboard: [gfx-noted]
Attached patch bug1331818.patchSplinter Review
Grey the button when DisableGPUProcess() is called.
Assignee: nobody → dvander
Status: NEW → ASSIGNED
Flags: needinfo?(dvander)
Attachment #8833597 - Flags: review?(gwright)
Attachment #8833597 - Flags: review?(gwright) → review+
Pushed by danderson@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/74d2f566ed65
Disabled "Terminate" button in about:support if no GPU process is running. (bug 1331818, r=gwright)
Backout by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a5fc021fd3f5
Backed out changeset 74d2f566ed65 for memory leaks in url = about:support
I didn't see leaks on try, but it's probably due to me not removing an Observer. Another try run with a fix: https://treeherder.mozilla.org/#/jobs?repo=try&revision=78346148b5661cf91509ef7f5842476e197d1474

It looks ok so I'll push again when the tree is open.
Flags: needinfo?(dvander)
Pushed by danderson@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/959e338a566a
Disabled "Terminate" button in about:support if no GPU process is running. (bug 1331818, r=gwright)
Flags: needinfo?(dvander)
You need to log in before you can comment on or make changes to this bug.