1331849 - Fix some wrong use of NS_NewNativeLocalFile in dom

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[Andrea Marchesini [:baku]]

Attachment: fileSystem2.patch

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8827744 [details] [diff] [review]
fileSystem2.patch

Do we need this in aurora/beta too? That other bug definitely, so possibly also this?

Is this tested on Windows with non-ascii folders and file names?

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5cf462d962ce
Replace NS_NewNativeLocalFile with NS_NewLocalFile in dom, r=smaug

Comment 4

[Andrea Marchesini [:baku]]

Comment on attachment 8827744 [details] [diff] [review]
fileSystem2.patch

Approval Request Comment
[Feature/Bug causing the regression]: Directory upload API, mainly.
[User impact if declined]: on windows, if a directory is called with a non-ascii name, that name can be wrongly encoded.
[Is this code covered by automated tests?]: none
[Has the fix been verified in Nightly?]: not yet 
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: We use a similar method but avoiding the double encoding.
[String changes made/needed]: none

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5cf462d962ce

Comment 6

[Gerry Chang [:gchang]]

Comment on attachment 8827744 [details] [diff] [review]
fileSystem2.patch

It's too late for 51 as we've built 51 RC2. Mark 51 won't fix and Beta51-. We can take this in Aurora52. Aurora52+.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/84e2bee07c24