Closed
Bug 1331881
Opened 7 years ago
Closed 7 years ago
Minimum wait duration and negative cache duration should be passed even if there is no match
Categories
(Toolkit :: Safe Browsing, defect, P2)
Toolkit
Safe Browsing
Tracking
()
RESOLVED
FIXED
mozilla54
Tracking | Status | |
---|---|---|
firefox54 | --- | fixed |
People
(Reporter: dimi, Assigned: dimi)
References
Details
(Whiteboard: #sbv4-m5)
Attachments
(1 file)
In nsUrlClassifierUtils::ParseFindFullHashResponseV4, we will pass all the information through OnCompleteHashFound callback. But minimum wait duration and negative cache duration in fullhash response are not bound to |matches|, so we should pass them separately.
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Attachment #8827822 -
Flags: review?(hchang)
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8827822 [details] Bug 1331881 - Minimum wait duration and negative cache duration should be passed even if there is no match. https://reviewboard.mozilla.org/r/105416/#review106894 Neat and clean patch. Thanks!
Attachment #8827822 -
Flags: review?(hchang) → review+
Assignee | ||
Updated•7 years ago
|
Attachment #8827822 -
Flags: review?(francois)
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8827822 [details] Bug 1331881 - Minimum wait duration and negative cache duration should be passed even if there is no match. https://reviewboard.mozilla.org/r/105416/#review107256
Attachment #8827822 -
Flags: review?(francois) → review+
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/autoland/rev/90586e26e66b Minimum wait duration and negative cache duration should be passed even if there is no match. r=francois,henry
Keywords: checkin-needed
Comment 5•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/90586e26e66b
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in
before you can comment on or make changes to this bug.
Description
•