Minimum wait duration and negative cache duration should be passed even if there is no match

RESOLVED FIXED in Firefox 54

Status

()

Toolkit
Safe Browsing
P2
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: dimi, Assigned: dimi)

Tracking

unspecified
mozilla54
Points:
---

Firefox Tracking Flags

(firefox54 fixed)

Details

(Whiteboard: #sbv4-m5)

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

a year ago
In nsUrlClassifierUtils::ParseFindFullHashResponseV4, we will pass all the information through OnCompleteHashFound callback. But minimum wait duration and negative cache duration in fullhash response are not bound to |matches|, so we should pass them separately.
Comment hidden (mozreview-request)
(Assignee)

Updated

a year ago
Attachment #8827822 - Flags: review?(hchang)

Comment 2

a year ago
mozreview-review
Comment on attachment 8827822 [details]
Bug 1331881 - Minimum wait duration and negative cache duration should be passed even if there is no match.

https://reviewboard.mozilla.org/r/105416/#review106894

Neat and clean patch. Thanks!
Attachment #8827822 - Flags: review?(hchang) → review+
(Assignee)

Updated

a year ago
Attachment #8827822 - Flags: review?(francois)

Comment 3

a year ago
mozreview-review
Comment on attachment 8827822 [details]
Bug 1331881 - Minimum wait duration and negative cache duration should be passed even if there is no match.

https://reviewboard.mozilla.org/r/105416/#review107256
Attachment #8827822 - Flags: review?(francois) → review+
(Assignee)

Updated

a year ago
Keywords: checkin-needed

Comment 4

a year ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/90586e26e66b
Minimum wait duration and negative cache duration should be passed even if there is no match. r=francois,henry
Keywords: checkin-needed

Comment 5

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/90586e26e66b
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.