1331897 - Tapping on the email field should always open the account management page

Status: RESOLVED WORKSFORME

(Firefox for iOS :: Firefox Accounts, defect, P3)

Description

[Catalin Suciu [:csuciu]]

Currently, after verifying a FxA sign in (by tapping on the emailed link), the 'Verify your email address' message, displayed in Settings under the email address, is not immediately dismissed.
If you tap on the email address while the message is still displayed, the account management page will open. 

After the 'Verify your email address' message gets dismissed, the email field is no longer tappable, so the account management page is no longer accessible from Settings. 

Expected: Tapping on the email address in Settings should always open the account management page.

Note: The account management options seem to be fully functional. Please see the video for further details.
https://www.youtube.com/watch?v=NHMh96-LkbI

Comment 1

[zhyhua04]

Attachment: Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2351

Comment 2

[zhyhua04]

(In reply to zhyhua04 from comment #1)
> Created attachment 8831019 [details] [review]
> Link to Github pull-request:
> https://github.com/mozilla-mobile/firefox-ios/pull/2351

Please ignore this attachment as I made some mistake. I'll submit a new attachment soon.

Comment 3

[zhyhua04]

Attachment: Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2352#attch-to-bugzilla

Comment 4

[Farhan Patel [:farhan]]

Hey zhyhua. Thanks for the PR. We've been talking about this internally. And it seems like there are a lot of bugs around showing the account view in the small webview. Do you think you can make it so that tapping on the email opens a new tab with your account logged in?

Comment 5

[zhyhua04]

(In reply to Farhan Patel from comment #4)
> Hey zhyhua. Thanks for the PR. We've been talking about this internally. And
> it seems like there are a lot of bugs around showing the account view in the
> small webview. Do you think you can make it so that tapping on the email
> opens a new tab with your account logged in?

Hi Farhan,
I had the interest but I don't understand what 'a new tab' is mentioned by you. Any tips?

Comment 6

[Farhan Patel [:farhan]]

Oh sorry. What I mean is that we want the Accounts page to open in the browser in its own tab just like any other web page would. 

We don't want in its own tiny window separate from the browser.

Comment 7

[zhyhua04]

(In reply to Farhan Patel from comment #6)
> Oh sorry. What I mean is that we want the Accounts page to open in the
> browser in its own tab just like any other web page would. 
> 
> We don't want in its own tiny window separate from the browser.

Clear now. I'll continue to work on this issue. Thanks for the explanation.

Comment 8

[zhyhua04]

Attachment: Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2371

Comment 9

[zhyhua04]

Attachment: Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2431

Make this PR rebased on latest changes after migration to Swift 3.0

Comment 10

[Catalin Suciu [:csuciu]]

This behavior was corrected.

Closing as WFM.