Tapping on the email field should always open the account management page

NEW
Unassigned

Status

()

P3
normal
Rank:
3
2 years ago
a year ago

People

(Reporter: csuciu, Unassigned)

Tracking

unspecified
All
iOS

Firefox Tracking Flags

(fxios-v6.0 affected, fxios-v7.0 affected, fxios10.0)

Details

(Whiteboard: [MobileCore] [IOSFXA])

Attachments

(4 attachments)

(Reporter)

Description

2 years ago
Currently, after verifying a FxA sign in (by tapping on the emailed link), the 'Verify your email address' message, displayed in Settings under the email address, is not immediately dismissed.
If you tap on the email address while the message is still displayed, the account management page will open. 

After the 'Verify your email address' message gets dismissed, the email field is no longer tappable, so the account management page is no longer accessible from Settings. 

Expected: Tapping on the email address in Settings should always open the account management page.

Note: The account management options seem to be fully functional. Please see the video for further details.
https://www.youtube.com/watch?v=NHMh96-LkbI
tracking-fxios: ? → 7.0+
Priority: -- → P2
Whiteboard: [MobileCore]

Comment 1

2 years ago
Created attachment 8831019 [details] [review]
Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2351
Attachment #8831019 - Flags: review?(fpatel)

Comment 2

2 years ago
(In reply to zhyhua04 from comment #1)
> Created attachment 8831019 [details] [review]
> Link to Github pull-request:
> https://github.com/mozilla-mobile/firefox-ios/pull/2351

Please ignore this attachment as I made some mistake. I'll submit a new attachment soon.

Updated

2 years ago
Attachment #8831019 - Flags: review?(fpatel) → review-
Hey zhyhua. Thanks for the PR. We've been talking about this internally. And it seems like there are a lot of bugs around showing the account view in the small webview. Do you think you can make it so that tapping on the email opens a new tab with your account logged in?

Comment 5

2 years ago
(In reply to Farhan Patel from comment #4)
> Hey zhyhua. Thanks for the PR. We've been talking about this internally. And
> it seems like there are a lot of bugs around showing the account view in the
> small webview. Do you think you can make it so that tapping on the email
> opens a new tab with your account logged in?

Hi Farhan,
I had the interest but I don't understand what 'a new tab' is mentioned by you. Any tips?
Oh sorry. What I mean is that we want the Accounts page to open in the browser in its own tab just like any other web page would. 

We don't want in its own tiny window separate from the browser.

Comment 7

2 years ago
(In reply to Farhan Patel from comment #6)
> Oh sorry. What I mean is that we want the Accounts page to open in the
> browser in its own tab just like any other web page would. 
> 
> We don't want in its own tiny window separate from the browser.

Clear now. I'll continue to work on this issue. Thanks for the explanation.

Comment 8

2 years ago
Created attachment 8833191 [details] [review]
Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2371
Attachment #8833191 - Flags: review?(fpatel)
Attachment #8831021 - Flags: review?(sleroux)

Comment 9

2 years ago
Created attachment 8838363 [details] [review]
Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2431

Make this PR rebased on latest changes after migration to Swift 3.0
Attachment #8838363 - Flags: review?(sleroux)

Updated

2 years ago
Attachment #8833191 - Flags: review?(fpatel) → review-
Attachment #8838363 - Flags: review?(sleroux)
See Also: → bug 1334460
tracking-fxios: 7.0+ → 8.0+

Updated

2 years ago
Priority: P2 → P3
(Reporter)

Updated

2 years ago
See Also: → bug 1354615
tracking-fxios: 8.0+ → 9.0
Rank: 3
Whiteboard: [MobileCore] → [MobileCore] [IOSFXA]
tracking-fxios: 9.0 → 9.1
tracking-fxios: 9.1 → 10.0
You need to log in before you can comment on or make changes to this bug.